Add fix for ossImagestream status by ptalgulk01 · Pull Request #6018 · openshift/machine-config-operator

ptalgulk01 · 2026-05-08T08:51:50Z

- What I did
Modified the function GetStatusOsImageStream(), and updated as per changes of MCP status.

Summary by CodeRabbit

Tests
- Improved validation of machine configuration pool status field extraction in the test suite to ensure accurate status information retrieval.

openshift-merge-bot · 2026-05-08T08:51:52Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

coderabbitai · 2026-05-08T08:52:03Z

Warning

Rate limit exceeded

@ptalgulk01 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 54 minutes and 46 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9aaceb60-602b-4e2a-90e2-422340817b2c

📥 Commits

Reviewing files that changed from the base of the PR and between 3002e75 and f7ad0e2.

📒 Files selected for processing (2)

test/extended-priv/machineconfigpool.go
test/extended-priv/mco_osimagestream.go

Walkthrough

The GetStatusOsImageStream() method's JSONPath query is updated to extract the name field from osImageStream status instead of querying the entire osImageStream object, narrowing the return value from an object to a string field.

Changes

JSONPath Query Refinement

Layer / File(s)	Summary
Implementation `test/extended-priv/machineconfigpool.go`	JSONPath in `GetStatusOsImageStream()` changed from `{.status.osImageStream}` to `{.status.osImageStream.name}` to extract only the name field instead of the entire object.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Add fix for ossImagestream status' contains a typo ('ossImagestream' instead of 'osImageStream') and is somewhat vague. While it references the correct function area, it doesn't clearly convey the specific change: querying the name field instead of the entire object.	Consider revising the title to be more specific and accurate, such as 'Query osImageStream name field instead of entire object in GetStatusOsImageStream()' to clearly describe the actual change.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR modifies only the GetStatusOsImageStream() method implementation, not Ginkgo test names. All test declarations in the repository use static, stable names without dynamic values.
Test Structure And Quality	✅ Passed	The modified file is a utility helper (84 methods) not a Ginkgo test suite. It contains no test blocks. The change updates method JSONPath logic. Test quality check doesn't apply.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests added. PR only modifies utility method in test helper file. Check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests added. PR only modifies the GetStatusOsImageStream() helper method in machineconfigpool.go, updating the JSONPath query. SNO compatibility check not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only a test utility method to change a JSONPath query. No deployment manifests, operator code, or scheduling constraints are introduced or modified.
Ote Binary Stdout Contract	✅ Passed	PR modifies only a test helper method in test/extended-priv/machineconfigpool.go (JSONPath query change). No process-level stdout writes. The OTE contract check does not apply to test utility methods.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR does not add new Ginkgo e2e tests. The modified file is a helper utility that only updates the GetStatusOsImageStream() method logic. Check is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

Generate code and open pull requests
Plan features and break down work
Investigate incidents and troubleshoot customer tickets together
Automate recurring tasks and respond to alerts with triggers
Summarize progress and report instantly

Built for teams:

Shared memory across your entire org—no repeating context
Per-thread sandboxes to safely plan and execute work
Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pablintino · 2026-05-08T10:25:38Z

/lgtm

openshift-merge-bot · 2026-05-08T10:26:07Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op-ocl-part1
/test e2e-gcp-op-ocl-part2
/test e2e-gcp-op-part1
/test e2e-gcp-op-part2
/test e2e-gcp-op-single-node
/test e2e-hypershift

openshift-ci · 2026-05-08T10:26:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino, ptalgulk01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [pablintino]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ptalgulk01 · 2026-05-08T13:05:20Z

/verified by running the scripts

openshift-ci-robot · 2026-05-08T13:05:32Z

@ptalgulk01: This PR has been marked as verified by running the scripts.

Details

In response to this:

/verified by running the scripts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ptalgulk01 · 2026-05-08T13:07:20Z

TC Logs

./machine-config-tests-ext run-test "[sig-mco][Suite:openshift/machine-config-operator/disruptive][Serial][Disruptive][OCPFeatureGate:OSStreams] MCO osImageStream [PolarionID:86495][OTP] Check default OS Image Stream [apigroup:machineconfiguration.openshift.io]" I0508 15:41:33.197603 3033948 test_context.go:566] The --provider flag is not set. Continuing as if --provider=skeleton had been used. Running Suite: - /home/ptalgulk/VSCode/mco/machine-config-operator =================================================================== Random Seed: 1778235093 - will randomize all specs

Will run 1 of 1 specs

[sig-mco][Suite:openshift/machine-config-operator/disruptive][Serial][Disruptive][OCPFeatureGate:OSStreams] MCO osImageStream [PolarionID:86495][OTP] Check default OS Image Stream [apigroup:machineconfiguration.openshift.io]
/home/ptalgulk/VSCode/mco/machine-config-operator/test/extended-priv/mco_osimagestream.go:85
STEP: Creating a kubernetes client @ 05/08/26 15:41:33.198
I0508 15:41:35.779441 3033948 client.go:164] configPath is now "/tmp/configfile2794526086"
I0508 15:41:35.779478 3033948 client.go:291] The user is now "e2e-test-mco-osimagestream-8vjf6-user"
I0508 15:41:35.779488 3033948 client.go:293] Creating project "e2e-test-mco-osimagestream-8vjf6"
I0508 15:41:36.132915 3033948 client.go:302] Waiting on permissions in project "e2e-test-mco-osimagestream-8vjf6" ...
I0508 15:41:37.147920 3033948 client.go:363] Waiting for ServiceAccount "default" to be provisioned...
I0508 15:41:37.507906 3033948 client.go:363] Waiting for ServiceAccount "builder" to be provisioned...
I0508 15:41:37.869624 3033948 client.go:363] Waiting for ServiceAccount "deployer" to be provisioned...
I0508 15:41:38.229675 3033948 client.go:373] Waiting for RoleBinding "system:image-builders" to be provisioned...
I0508 15:41:38.492044 3033948 client.go:373] Waiting for RoleBinding "system:deployers" to be provisioned...
I0508 15:41:38.752738 3033948 client.go:373] Waiting for RoleBinding "system:image-pullers" to be provisioned...
I0508 15:41:39.015308 3033948 client.go:404] Project "e2e-test-mco-osimagestream-8vjf6" has been fully provisioned.
I0508 15:41:39.015728 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get featuregate cluster -o jsonpath={.status.featureGates[0].enabled[*].name}'
I0508 15:41:40.133376 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp'
NAME CONFIG UPDATED UPDATING DEGRADED MACHINECOUNT READYMACHINECOUNT UPDATEDMACHINECOUNT DEGRADEDMACHINECOUNT AGE
master rendered-master-e9aadfcb3299db9a28eecf95e08e1866 True False False 3 3 3 0 4h29m
worker rendered-worker-9a90e226fa5d926b2fd72511be513ca6 True False False 3 3 3 0 4h29m
I0508 15:41:40.958890 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp worker -o jsonpath={.status.machineCount}'
I0508 15:41:41.791297 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp worker -o jsonpath={.status.machineCount}'
STEP: MCO Preconditions Checks @ 05/08/26 15:41:42.574
May 8 15:41:43.659: INFO: Check that master pool is ready for testing
I0508 15:41:43.659858 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp master -o jsonpath={.status.machineCount}'
May 8 15:41:44.480: INFO: Num nodes: 3, wait time per node 13 minutes
May 8 15:41:44.480: INFO: Increase waiting time because it is master pool
May 8 15:41:44.480: INFO: Waiting 3m54s for MCP master to be completed.
I0508 15:41:44.480752 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp master -o jsonpath={.status.conditions[?(@.type=="Degraded")].status}'
I0508 15:41:45.312682 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp master -o jsonpath={.status.conditions[?(@.type=="Updated")].status}'
May 8 15:41:46.123: INFO: MCP 'master' is ready for testing
May 8 15:41:46.123: INFO: Check that worker pool is ready for testing
I0508 15:41:46.123711 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp worker -o jsonpath={.status.machineCount}'
May 8 15:41:46.907: INFO: Num nodes: 3, wait time per node 13 minutes
May 8 15:41:46.907: INFO: Waiting 3m0s for MCP worker to be completed.
I0508 15:41:46.907773 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp worker -o jsonpath={.status.conditions[?(@.type=="Degraded")].status}'
I0508 15:41:47.745281 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp worker -o jsonpath={.status.conditions[?(@.type=="Updated")].status}'
May 8 15:41:48.553: INFO: MCP 'worker' is ready for testing
May 8 15:41:48.553: INFO: Wait for MCC to get the leader lease
I0508 15:41:48.553399 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get pod -n openshift-machine-config-operator -l k8s-app=machine-config-controller -o jsonpath={.items[0].metadata.name}'
I0508 15:41:49.593811 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig logs -n openshift-machine-config-operator -c machine-config-controller machine-config-controller-fddb8c7b6-pc4n4'
May 8 15:41:51.699: INFO: End of MCO Preconditions

I0508 15:41:51.699790 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get osimagestream cluster -o jsonpath={.status.defaultStream}'
I0508 15:41:52.499347 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get osimagestream cluster -o jsonpath={.status.availableStreams[*].name}'
May 8 15:41:53.303: INFO: OSImageStream default stream: rhel-9
May 8 15:41:53.303: INFO: OSImageStream available streams: [rhel-10 rhel-9]
I0508 15:41:53.303883 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get osimagestream cluster -o jsonpath={.status.availableStreams[?(@.name=="rhel-10")].osImage}'
I0508 15:41:54.170747 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get osimagestream cluster -o jsonpath={.status.availableStreams[?(@.name=="rhel-10")].osExtensionsImage}'
May 8 15:41:54.980: INFO: Stream 'rhel-10':
May 8 15:41:54.980: INFO: osImage: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:60d25127bf551986db8ba3296eca5774345fbf4468520e37f276e581a781c7f9
May 8 15:41:54.980: INFO: osExtensionsImage: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:f4241aee54896929e345dbdaab81c0f3c2feacc31069e18ccd9df81149de208a
I0508 15:41:54.980356 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get osimagestream cluster -o jsonpath={.status.availableStreams[?(@.name=="rhel-9")].osImage}'
I0508 15:41:55.796020 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get osimagestream cluster -o jsonpath={.status.availableStreams[?(@.name=="rhel-9")].osExtensionsImage}'
May 8 15:41:56.604: INFO: Stream 'rhel-9':
May 8 15:41:56.604: INFO: osImage: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:636d4e9653daeae9811968ac37bbf66e5b36bfe8d182fc3695e8cbf1227c925d
May 8 15:41:56.604: INFO: osExtensionsImage: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:00ea4c986bc005b78d5ba60ef1e5a837ebc2fc82f8049c2694ed9ac875ae54f6
STEP: Get the default osImageStream @ 05/08/26 15:41:56.604
I0508 15:41:56.605047 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get osimagestream cluster -o jsonpath={.status.defaultStream}'
May 8 15:41:57.438: INFO: Default OS Image Stream: rhel-9
May 8 15:41:57.438: INFO: OK!

STEP: Check that MCPs with no .spec.osImageStream configured use the default stream @ 05/08/26 15:41:57.438

I0508 15:41:58.511048 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp master -o jsonpath={.spec.osImageStream.name}'
STEP: Validate that <Kind: mcp, Name: master, Namespace: > is using osImageStream 'rhel-9' @ 05/08/26 15:42:23.467
I0508 15:42:23.468050 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get osimagestream cluster -o jsonpath={.status.availableStreams[?(@.name=="rhel-9")].osImage}'
I0508 15:42:50.034181 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get -n openshift-machine-config-operator pods machine-config-operator-74b5c6b5cf-65rpm -o jsonpath={.spec.nodeName}'
May 8 15:42:51.131: INFO: MCO operator pod running in node: ip-10-0-55-254.us-east-2.compute.internal
I0508 15:42:51.132191 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get node ip-10-0-8-178.us-east-2.compute.internal -o jsonpath={.metadata}'
I0508 15:42:53.405282 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get node ip-10-0-55-254.us-east-2.compute.internal -o jsonpath={.metadata}'
I0508 15:42:54.457150 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get node ip-10-0-87-176.us-east-2.compute.internal -o jsonpath={.metadata}'
I0508 15:42:55.694729 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get node ip-10-0-55-254.us-east-2.compute.internal -o jsonpath={.metadata}'
May 8 15:42:56.751: INFO: Sorted master nodes: [ip-10-0-8-178.us-east-2.compute.internal ip-10-0-87-176.us-east-2.compute.internal ip-10-0-55-254.us-east-2.compute.internal]
May 8 15:42:56.751: INFO: Checking osImage on node ip-10-0-8-178.us-east-2.compute.internal
I0508 15:42:57.797136 3033948 client.go:743] showInfo is true
I0508 15:42:57.797186 3033948 client.go:745] Running 'oc --namespace=e2e-test-mco-osimagestream-8vjf6 --kubeconfig=kubeconfig debug node/ip-10-0-8-178.us-east-2.compute.internal -- chroot /host rpm-ostree status --json'
May 8 15:43:00.529: INFO: Current booted container-image-reference: "ostree-unverified-registry:quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:636d4e9653daeae9811968ac37bbf66e5b36bfe8d182fc3695e8cbf1227c925d"
May 8 15:43:00.529: INFO: Booted image: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:636d4e9653daeae9811968ac37bbf66e5b36bfe8d182fc3695e8cbf1227c925d
May 8 15:43:00.529: INFO: ip-10-0-8-178.us-east-2.compute.internal is correctly using osImage from stream 'rhel-9'
May 8 15:43:00.529: INFO: Checking MCP status.osImageStream
I0508 15:43:00.529301 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp master -o jsonpath={.status.osImageStream.name}'
May 8 15:43:01.335: INFO: <Kind: mcp, Name: master, Namespace: > correctly reports osImageStream 'rhel-9' in status
May 8 15:43:01.335: INFO: Checking RHEL version starts with '9' to match stream name pattern
I0508 15:43:02.972291 3033948 client.go:743] showInfo is false
May 8 15:43:05.547: INFO: Node ip-10-0-8-178.us-east-2.compute.internal RHEL_VERSION 9.8
May 8 15:43:05.547: INFO: ip-10-0-8-178.us-east-2.compute.internal is correctly running RHEL version starting with 9
May 8 15:43:05.547: INFO: OK!

I0508 15:43:05.547464 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp worker -o jsonpath={.spec.osImageStream.name}'
STEP: Validate that <Kind: mcp, Name: worker, Namespace: > is using osImageStream 'rhel-9' @ 05/08/26 15:43:35.496
I0508 15:43:35.496666 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get osimagestream cluster -o jsonpath={.status.availableStreams[?(@.name=="rhel-9")].osImage}'
I0508 15:44:03.711796 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get node ip-10-0-34-124.us-east-2.compute.internal -o jsonpath={.metadata}'
I0508 15:44:04.978062 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get node ip-10-0-27-160.us-east-2.compute.internal -o jsonpath={.metadata}'
I0508 15:44:06.177166 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get node ip-10-0-91-41.us-east-2.compute.internal -o jsonpath={.metadata}'
I0508 15:44:07.226769 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get node ip-10-0-34-124.us-east-2.compute.internal -o jsonpath={.metadata}'
May 8 15:44:08.286: INFO: Checking osImage on node ip-10-0-27-160.us-east-2.compute.internal
I0508 15:44:10.273061 3033948 client.go:743] showInfo is true
I0508 15:44:10.273164 3033948 client.go:745] Running 'oc --namespace=e2e-test-mco-osimagestream-8vjf6 --kubeconfig=kubeconfig debug node/ip-10-0-27-160.us-east-2.compute.internal -- chroot /host rpm-ostree status --json'
May 8 15:44:14.582: INFO: Current booted container-image-reference: "ostree-unverified-registry:quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:636d4e9653daeae9811968ac37bbf66e5b36bfe8d182fc3695e8cbf1227c925d"
May 8 15:44:14.582: INFO: Booted image: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:636d4e9653daeae9811968ac37bbf66e5b36bfe8d182fc3695e8cbf1227c925d
May 8 15:44:14.582: INFO: ip-10-0-27-160.us-east-2.compute.internal is correctly using osImage from stream 'rhel-9'
May 8 15:44:14.582: INFO: Checking MCP status.osImageStream
I0508 15:44:14.582514 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp worker -o jsonpath={.status.osImageStream.name}'
May 8 15:44:15.386: INFO: <Kind: mcp, Name: worker, Namespace: > correctly reports osImageStream 'rhel-9' in status
May 8 15:44:15.386: INFO: Checking RHEL version starts with '9' to match stream name pattern
I0508 15:44:17.049694 3033948 client.go:743] showInfo is false
May 8 15:44:19.872: INFO: Node ip-10-0-27-160.us-east-2.compute.internal RHEL_VERSION 9.8
May 8 15:44:19.872: INFO: ip-10-0-27-160.us-east-2.compute.internal is correctly running RHEL version starting with 9
May 8 15:44:19.872: INFO: OK!

May 8 15:44:19.872: INFO: OK!

I0508 15:44:20.648149 3033948 client.go:421] Deleted {user.openshift.io/v1, Resource=users e2e-test-mco-osimagestream-8vjf6-user}, err:
I0508 15:44:20.910941 3033948 client.go:421] Deleted {oauth.openshift.io/v1, Resource=oauthclients e2e-client-e2e-test-mco-osimagestream-8vjf6}, err:
I0508 15:44:21.173173 3033948 client.go:421] Deleted {oauth.openshift.io/v1, Resource=oauthaccesstokens sha256~rClW8VMwBM-hl0jnru12-PQDpfjwSUWyCaxlHH9d0rE}, err:
STEP: Destroying namespace "e2e-test-mco-osimagestream-8vjf6" for this suite. @ 05/08/26 15:44:21.173
• [168.237 seconds]

Ran 1 of 1 Specs in 168.237 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
[
{
"name": "[sig-mco][Suite:openshift/machine-config-operator/disruptive][Serial][Disruptive][OCPFeatureGate:OSStreams] MCO osImageStream [PolarionID:86495][OTP] Check default OS Image Stream [apigroup:machineconfiguration.openshift.io]",
"lifecycle": "blocking",
"duration": 168237,
"startTime": "2026-05-08 10:11:33.197725 UTC",
"endTime": "2026-05-08 10:14:21.434792 UTC",
"result": "passed",
"output": " STEP: Creating a kubernetes client @ 05/08/26 15:41:33.198\nI0508 15:41:35.779441 3033948 client.go:164] configPath is now "/tmp/configfile2794526086"\nI0508 15:41:35.779478 3033948 client.go:291] The user is now "e2e-test-mco-osimagestream-8vjf6-user"\nI0508 15:41:35.779488 3033948 client.go:293] Creating project "e2e-test-mco-osimagestream-8vjf6"\nI0508 15:41:36.132915 3033948 client.go:302] Waiting on permissions in project "e2e-test-mco-osimagestream-8vjf6" ...\nI0508 15:41:37.147920 3033948 client.go:363] Waiting for ServiceAccount "default" to be provisioned...\nI0508 15:41:37.507906 3033948 client.go:363] Waiting for ServiceAccount "builder" to be provisioned...\nI0508 15:41:37.869624 3033948 client.go:363] Waiting for ServiceAccount "deployer" to be provisioned...\nI0508 15:41:38.229675 3033948 client.go:373] Waiting for RoleBinding "system:image-builders" to be provisioned...\nI0508 15:41:38.492044 3033948 client.go:373] Waiting for RoleBinding "system:deployers" to be provisioned...\nI0508 15:41:38.752738 3033948 client.go:373] Waiting for RoleBinding "system:image-pullers" to be provisioned...\nI0508 15:41:39.015308 3033948 client.go:404] Project "e2e-test-mco-osimagestream-8vjf6" has been fully provisioned.\nI0508 15:41:39.015728 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get featuregate cluster -o jsonpath={.status.featureGates[0].enabled[].name}'\nI0508 15:41:40.133376 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp'\nNAME CONFIG UPDATED UPDATING DEGRADED MACHINECOUNT READYMACHINECOUNT UPDATEDMACHINECOUNT DEGRADEDMACHINECOUNT AGE\nmaster rendered-master-e9aadfcb3299db9a28eecf95e08e1866 True False False 3 3 3 0 4h29m\nworker rendered-worker-9a90e226fa5d926b2fd72511be513ca6 True False False 3 3 3 0 4h29m\nI0508 15:41:40.958890 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp worker -o jsonpath={.status.machineCount}'\nI0508 15:41:41.791297 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp worker -o jsonpath={.status.machineCount}'\n STEP: MCO Preconditions Checks @ 05/08/26 15:41:42.574\nMay 8 15:41:43.659: INFO: Check that master pool is ready for testing\nI0508 15:41:43.659858 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp master -o jsonpath={.status.machineCount}'\nMay 8 15:41:44.480: INFO: Num nodes: 3, wait time per node 13 minutes\nMay 8 15:41:44.480: INFO: Increase waiting time because it is master pool\nMay 8 15:41:44.480: INFO: Waiting 3m54s for MCP master to be completed.\nI0508 15:41:44.480752 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp master -o jsonpath={.status.conditions[?(@.type=="Degraded")].status}'\nI0508 15:41:45.312682 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp master -o jsonpath={.status.conditions[?(@.type=="Updated")].status}'\nMay 8 15:41:46.123: INFO: MCP 'master' is ready for testing\nMay 8 15:41:46.123: INFO: Check that worker pool is ready for testing\nI0508 15:41:46.123711 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp worker -o jsonpath={.status.machineCount}'\nMay 8 15:41:46.907: INFO: Num nodes: 3, wait time per node 13 minutes\nMay 8 15:41:46.907: INFO: Waiting 3m0s for MCP worker to be completed.\nI0508 15:41:46.907773 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp worker -o jsonpath={.status.conditions[?(@.type=="Degraded")].status}'\nI0508 15:41:47.745281 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp worker -o jsonpath={.status.conditions[?(@.type=="Updated")].status}'\nMay 8 15:41:48.553: INFO: MCP 'worker' is ready for testing\nMay 8 15:41:48.553: INFO: Wait for MCC to get the leader lease\nI0508 15:41:48.553399 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get pod -n openshift-machine-config-operator -l k8s-app=machine-config-controller -o jsonpath={.items[0].metadata.name}'\nI0508 15:41:49.593811 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig logs -n openshift-machine-config-operator -c machine-config-controller machine-config-controller-fddb8c7b6-pc4n4'\nMay 8 15:41:51.699: INFO: End of MCO Preconditions\n\nI0508 15:41:51.699790 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get osimagestream cluster -o jsonpath={.status.defaultStream}'\nI0508 15:41:52.499347 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get osimagestream cluster -o jsonpath={.status.availableStreams[].name}'\nMay 8 15:41:53.303: INFO: OSImageStream default stream: rhel-9\nMay 8 15:41:53.303: INFO: OSImageStream available streams: [rhel-10 rhel-9]\nI0508 15:41:53.303883 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get osimagestream cluster -o jsonpath={.status.availableStreams[?(@.name=="rhel-10")].osImage}'\nI0508 15:41:54.170747 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get osimagestream cluster -o jsonpath={.status.availableStreams[?(@.name=="rhel-10")].osExtensionsImage}'\nMay 8 15:41:54.980: INFO: Stream 'rhel-10':\nMay 8 15:41:54.980: INFO: osImage: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:60d25127bf551986db8ba3296eca5774345fbf4468520e37f276e581a781c7f9\nMay 8 15:41:54.980: INFO: osExtensionsImage: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:f4241aee54896929e345dbdaab81c0f3c2feacc31069e18ccd9df81149de208a\nI0508 15:41:54.980356 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get osimagestream cluster -o jsonpath={.status.availableStreams[?(@.name=="rhel-9")].osImage}'\nI0508 15:41:55.796020 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get osimagestream cluster -o jsonpath={.status.availableStreams[?(@.name=="rhel-9")].osExtensionsImage}'\nMay 8 15:41:56.604: INFO: Stream 'rhel-9':\nMay 8 15:41:56.604: INFO: osImage: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:636d4e9653daeae9811968ac37bbf66e5b36bfe8d182fc3695e8cbf1227c925d\nMay 8 15:41:56.604: INFO: osExtensionsImage: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:00ea4c986bc005b78d5ba60ef1e5a837ebc2fc82f8049c2694ed9ac875ae54f6\n STEP: Get the default osImageStream @ 05/08/26 15:41:56.604\nI0508 15:41:56.605047 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get osimagestream cluster -o jsonpath={.status.defaultStream}'\nMay 8 15:41:57.438: INFO: Default OS Image Stream: rhel-9\nMay 8 15:41:57.438: INFO: OK!\n\n STEP: Check that MCPs with no .spec.osImageStream configured use the default stream @ 05/08/26 15:41:57.438\nI0508 15:41:58.511048 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp master -o jsonpath={.spec.osImageStream.name}'\n STEP: Validate that \u003cKind: mcp, Name: master, Namespace: \u003e is using osImageStream 'rhel-9' @ 05/08/26 15:42:23.467\nI0508 15:42:23.468050 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get osimagestream cluster -o jsonpath={.status.availableStreams[?(@.name=="rhel-9")].osImage}'\nI0508 15:42:50.034181 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get -n openshift-machine-config-operator pods machine-config-operator-74b5c6b5cf-65rpm -o jsonpath={.spec.nodeName}'\nMay 8 15:42:51.131: INFO: MCO operator pod running in node: ip-10-0-55-254.us-east-2.compute.internal\nI0508 15:42:51.132191 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get node ip-10-0-8-178.us-east-2.compute.internal -o jsonpath={.metadata}'\nI0508 15:42:53.405282 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get node ip-10-0-55-254.us-east-2.compute.internal -o jsonpath={.metadata}'\nI0508 15:42:54.457150 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get node ip-10-0-87-176.us-east-2.compute.internal -o jsonpath={.metadata}'\nI0508 15:42:55.694729 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get node ip-10-0-55-254.us-east-2.compute.internal -o jsonpath={.metadata}'\nMay 8 15:42:56.751: INFO: Sorted master nodes: [ip-10-0-8-178.us-east-2.compute.internal ip-10-0-87-176.us-east-2.compute.internal ip-10-0-55-254.us-east-2.compute.internal]\nMay 8 15:42:56.751: INFO: Checking osImage on node ip-10-0-8-178.us-east-2.compute.internal\nI0508 15:42:57.797136 3033948 client.go:743] showInfo is true\nI0508 15:42:57.797186 3033948 client.go:745] Running 'oc --namespace=e2e-test-mco-osimagestream-8vjf6 --kubeconfig=kubeconfig debug node/ip-10-0-8-178.us-east-2.compute.internal -- chroot /host rpm-ostree status --json'\nMay 8 15:43:00.529: INFO: Current booted container-image-reference: "ostree-unverified-registry:quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:636d4e9653daeae9811968ac37bbf66e5b36bfe8d182fc3695e8cbf1227c925d"\nMay 8 15:43:00.529: INFO: Booted image: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:636d4e9653daeae9811968ac37bbf66e5b36bfe8d182fc3695e8cbf1227c925d\nMay 8 15:43:00.529: INFO: ip-10-0-8-178.us-east-2.compute.internal is correctly using osImage from stream 'rhel-9'\nMay 8 15:43:00.529: INFO: Checking MCP status.osImageStream\nI0508 15:43:00.529301 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp master -o jsonpath={.status.osImageStream.name}'\nMay 8 15:43:01.335: INFO: \u003cKind: mcp, Name: master, Namespace: \u003e correctly reports osImageStream 'rhel-9' in status\nMay 8 15:43:01.335: INFO: Checking RHEL version starts with '9' to match stream name pattern\nI0508 15:43:02.972291 3033948 client.go:743] showInfo is false\nMay 8 15:43:05.547: INFO: Node ip-10-0-8-178.us-east-2.compute.internal RHEL_VERSION 9.8\nMay 8 15:43:05.547: INFO: ip-10-0-8-178.us-east-2.compute.internal is correctly running RHEL version starting with 9\nMay 8 15:43:05.547: INFO: OK!\n\nI0508 15:43:05.547464 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp worker -o jsonpath={.spec.osImageStream.name}'\n STEP: Validate that \u003cKind: mcp, Name: worker, Namespace: \u003e is using osImageStream 'rhel-9' @ 05/08/26 15:43:35.496\nI0508 15:43:35.496666 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get osimagestream cluster -o jsonpath={.status.availableStreams[?(@.name=="rhel-9")].osImage}'\nI0508 15:44:03.711796 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get node ip-10-0-34-124.us-east-2.compute.internal -o jsonpath={.metadata}'\nI0508 15:44:04.978062 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get node ip-10-0-27-160.us-east-2.compute.internal -o jsonpath={.metadata}'\nI0508 15:44:06.177166 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get node ip-10-0-91-41.us-east-2.compute.internal -o jsonpath={.metadata}'\nI0508 15:44:07.226769 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get node ip-10-0-34-124.us-east-2.compute.internal -o jsonpath={.metadata}'\nMay 8 15:44:08.286: INFO: Checking osImage on node ip-10-0-27-160.us-east-2.compute.internal\nI0508 15:44:10.273061 3033948 client.go:743] showInfo is true\nI0508 15:44:10.273164 3033948 client.go:745] Running 'oc --namespace=e2e-test-mco-osimagestream-8vjf6 --kubeconfig=kubeconfig debug node/ip-10-0-27-160.us-east-2.compute.internal -- chroot /host rpm-ostree status --json'\nMay 8 15:44:14.582: INFO: Current booted container-image-reference: "ostree-unverified-registry:quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:636d4e9653daeae9811968ac37bbf66e5b36bfe8d182fc3695e8cbf1227c925d"\nMay 8 15:44:14.582: INFO: Booted image: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:636d4e9653daeae9811968ac37bbf66e5b36bfe8d182fc3695e8cbf1227c925d\nMay 8 15:44:14.582: INFO: ip-10-0-27-160.us-east-2.compute.internal is correctly using osImage from stream 'rhel-9'\nMay 8 15:44:14.582: INFO: Checking MCP status.osImageStream\nI0508 15:44:14.582514 3033948 client.go:718] Running 'oc --kubeconfig=kubeconfig get mcp worker -o jsonpath={.status.osImageStream.name}'\nMay 8 15:44:15.386: INFO: \u003cKind: mcp, Name: worker, Namespace: \u003e correctly reports osImageStream 'rhel-9' in status\nMay 8 15:44:15.386: INFO: Checking RHEL version starts with '9' to match stream name pattern\nI0508 15:44:17.049694 3033948 client.go:743] showInfo is false\nMay 8 15:44:19.872: INFO: Node ip-10-0-27-160.us-east-2.compute.internal RHEL_VERSION 9.8\nMay 8 15:44:19.872: INFO: ip-10-0-27-160.us-east-2.compute.internal is correctly running RHEL version starting with 9\nMay 8 15:44:19.872: INFO: OK!\n\nMay 8 15:44:19.872: INFO: OK!\n\nI0508 15:44:20.648149 3033948 client.go:421] Deleted {user.openshift.io/v1, Resource=users e2e-test-mco-osimagestream-8vjf6-user}, err: \u003cnil\u003e\nI0508 15:44:20.910941 3033948 client.go:421] Deleted {oauth.openshift.io/v1, Resource=oauthclients e2e-client-e2e-test-mco-osimagestream-8vjf6}, err: \u003cnil\u003e\nI0508 15:44:21.173173 3033948 client.go:421] Deleted {oauth.openshift.io/v1, Resource=oauthaccesstokens sha256~rClW8VMwBM-hl0jnru12-PQDpfjwSUWyCaxlHH9d0rE}, err: \u003cnil\u003e\n STEP: Destroying namespace "e2e-test-mco-osimagestream-8vjf6" for this suite. @ 05/08/26 15:44:21.173\n"
}
]

openshift-ci · 2026-05-08T13:52:23Z

@ptalgulk01: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci Bot requested review from dkhater-redhat and yuqi-zhang May 8, 2026 08:52

Add fix for ossImagestream status

f7ad0e2

ptalgulk01 force-pushed the ppt/osstream-fix branch from 3002e75 to f7ad0e2 Compare May 8, 2026 10:05

openshift-ci Bot assigned pablintino May 8, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add fix for ossImagestream status#6018

Add fix for ossImagestream status#6018
ptalgulk01 wants to merge 1 commit intoopenshift:mainfrom
ptalgulk01:ppt/osstream-fix

ptalgulk01 commented May 8, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

openshift-merge-bot Bot commented May 8, 2026

Uh oh!

coderabbitai Bot commented May 8, 2026 •

edited

Loading

Rate limit exceeded

❌ Failed checks (1 inconclusive)

Uh oh!

pablintino commented May 8, 2026

Uh oh!

openshift-merge-bot Bot commented May 8, 2026

Uh oh!

openshift-ci Bot commented May 8, 2026

Uh oh!

ptalgulk01 commented May 8, 2026

Uh oh!

openshift-ci-robot commented May 8, 2026

Uh oh!

ptalgulk01 commented May 8, 2026

Will run 1 of 1 specs

Uh oh!

openshift-ci Bot commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ptalgulk01 commented May 8, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented May 8, 2026

Uh oh!

coderabbitai Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Changes

Estimated code review effort

❌ Failed checks (1 inconclusive)

Uh oh!

pablintino commented May 8, 2026

Uh oh!

openshift-merge-bot Bot commented May 8, 2026

Uh oh!

openshift-ci Bot commented May 8, 2026

Uh oh!

ptalgulk01 commented May 8, 2026

Uh oh!

openshift-ci-robot commented May 8, 2026

Uh oh!

ptalgulk01 commented May 8, 2026

Will run 1 of 1 specs

Uh oh!

openshift-ci Bot commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ptalgulk01 commented May 8, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 8, 2026 •

edited

Loading