Skip to content

Allow copying from scmsync#2081

Open
hramrach wants to merge 1 commit intoopenSUSE:masterfrom
hramrach:master
Open

Allow copying from scmsync#2081
hramrach wants to merge 1 commit intoopenSUSE:masterfrom
hramrach:master

Conversation

@hramrach
Copy link
Copy Markdown
Contributor

Fixes: ade0426 ("Support copying from an scmsync source, when target exists.")

The 'when target exists' restriction is superfluous.

Copying was never about tracking the source, SCM or otherwise.

@adrianschroeter
Copy link
Copy Markdown
Member

point is that you need to decide if you want to use git in the target or not:

  1. If you want keep git, the code would need to setup the scmsync, maybe with a concrete commit hash when you the user does not want to follow.
  2. If you don't want to keep git, the extra tracking files should be removed instead. Blindly copying content creates a very misleading content otherwise.

@hramrach
Copy link
Copy Markdown
Contributor Author

What are the 'extra tracking files' here?

Why would it not be a problem if the package already exists but would be a problem when it's a new package?

@hramrach
Copy link
Copy Markdown
Contributor Author

hramrach commented Apr 1, 2026

ping?

Fixes: ade0426 ("Support copying from an scmsync source, when target exists.")

The 'when target exists' restriction is superfluous.

Copying was never about tracking the source, SCM or otherwise.
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 33.94%. Comparing base (fb9ba30) to head (df87e63).
⚠️ Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
osc/core.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2081      +/-   ##
==========================================
+ Coverage   33.90%   33.94%   +0.04%     
==========================================
  Files         196      199       +3     
  Lines       26988    27020      +32     
==========================================
+ Hits         9151     9173      +22     
- Misses      17837    17847      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants