feature: shows number of annotated frames by camiloHimura · Pull Request #6076 · open-edge-platform/training_extensions

camiloHimura · 2026-04-10T12:44:01Z

Summary

#5903 Dataset - for videos, the review status icon on the thumbnail should display the number of annotated frames out of the total (e.g. "44 / 350").

Gallery	Sidebar

How to test

Checklist

The PR title and description are clear and descriptive
I have manually tested the changes
All changes are covered by automated tests
All related issues are linked to this PR (if applicable)
Documentation has been updated (if applicable)

github-actions · 2026-04-10T12:48:08Z

🐳 Docker image sizes

Device	Size
`xpu`	10572.7 MB (10.32 GB)
`cuda`	10219.1 MB (9.98 GB)
`cpu`	3604.1 MB (3.52 GB)

Copilot

Pull request overview

Adds UI support for displaying “annotated frames / total frames” for video media items, and ensures relevant dataset media queries are refreshed after annotation updates so counts stay in sync.

Changes:

Update the video thumbnail indicator to show annotated_frame_count / frame_count.
Invalidate the dataset media listing query after saving annotations to refresh annotated frame counts.
Minor cleanup of $api params object formatting.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
application/ui/src/shared/annotator/annotation-actions-provider.component.tsx	Adds invalidation for `/dataset/media` so media list data (incl. counts) refreshes after annotation saves.
application/ui/src/hooks/use-get-dataset-media-items.hook.ts	Refactors the query params object formatting for the infinite media query.
application/ui/src/components/media-thumbnail/media-thumbnail.component.tsx	Updates the video overlay label to display “annotated / total frames”.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-04-10T15:56:16Z

📊 Test coverage report

Metric	Coverage
Lines	57.4%
Functions	79.0%
Branches	87.9%
Statements	57.4%

dwesolow · 2026-04-13T07:21:25Z

+        incrementCachedAnnotatedFrameCount(queryClient, video2);
+
+        const data = getMediaQueryData(queryClient);
+        expect(data?.pages[0].items[0]).toEqual(expect.objectContaining({ annotated_frame_count: 2 }));


video1.annotated_frame_count

I don't see this being updated

that commit didn't go through but it is on now

jpggvilaca · 2026-04-15T07:34:02Z

+
+import { InfiniteData, QueryClient } from '@tanstack/react-query';
+
+import { SchemaMediaWithPagination } from '../../api/openapi-spec';


add a new type to shared-types and import that here instead of importing from openapi directly

jpggvilaca · 2026-04-15T07:36:10Z

@@ -75,9 +78,7 @@ export const AnnotationActionsProvider = ({
                [
                    'get',
                    '/api/projects/{project_id}/dataset/media/{media_id}/frames',


why dont we invalidate '/api/projects/{project_id}/dataset/media' and avoid doing the optimistic update with the new util?

It was my initial approach, but Copilot pointed out that for large datasets it would require refetching multiple pages, which could lead to performance degradation. #6076 (comment)

dwesolow · 2026-04-15T07:37:34Z

+                aria-label='annotated frames'
+            >
+                <Content>
+                    <Text>Total frames: {frameCount}</Text>


IMO the order should be reverted to stay consisted with the flow number of annotated / number of total

dwesolow · 2026-04-15T07:38:56Z

-            params: { path: { media_id: mediaItem.id, project_id: projectId }, query },
-            body: { annotations: annotationsDTO, subset: subset ?? undefined },
-        });
+        await saveMutation


For later: use try catch and move incrementCachedAnnotatedFrameCount and undoRedoActions.reset to the try block.

dwesolow · 2026-04-15T13:35:20Z

+            alignItems={'center'}
+            UNSAFE_className={classes.videoIndicator}
+        >
+            {formatDurationText(duration)}


IIRC Mariusz wants display the following:
45s = 0:45, not 00:00:45,
1h 45 min 30 s= 1:45:30, not 01:45:30

Could you please make sure that we can reuse formatDurationText?

I'll have a dedicated Pr for it

Copilot AI review requested due to automatic review settings April 10, 2026 12:44

camiloHimura added the Geti UI Issues related to Geti application frontend label Apr 10, 2026

camiloHimura requested a review from a team as a code owner April 10, 2026 12:44

Copilot started reviewing on behalf of camiloHimura April 10, 2026 12:45 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Comment thread application/ui/src/components/media-thumbnail/media-thumbnail.component.tsx Outdated

Comment thread application/ui/src/shared/annotator/annotation-actions-provider.component.tsx

dwesolow reviewed Apr 13, 2026

View reviewed changes

Comment thread application/ui/src/components/media-thumbnail/media-thumbnail.component.tsx Outdated

dwesolow reviewed Apr 13, 2026

View reviewed changes

Comment thread application/ui/src/shared/annotator/annotation-actions-provider.component.tsx Outdated

dwesolow reviewed Apr 13, 2026

View reviewed changes

Comment thread application/ui/src/shared/annotator/util.test.ts Outdated

dwesolow reviewed Apr 13, 2026

View reviewed changes

Comment thread application/ui/src/shared/annotator/util.ts Outdated

camiloHimura force-pushed the ccolora11/5903-number-annotated-frames branch from 5f8fe1b to 56a10d5 Compare April 14, 2026 15:10

jpggvilaca reviewed Apr 15, 2026

View reviewed changes

dwesolow reviewed Apr 15, 2026

View reviewed changes

camiloHimura added 7 commits April 15, 2026 15:01

gallery shows number of annotated frames

6d52ea8

fix unit tests

736c752

remove leftover code

f8c6de2

add contextual help

c0ec4c1

add aria-label

bcbe191

media gallery shows video duration

1663fdc

media item contextual help

18b45d3

camiloHimura force-pushed the ccolora11/5903-number-annotated-frames branch from abde538 to 18b45d3 Compare April 15, 2026 13:02

camiloHimura requested review from dwesolow and jpggvilaca April 15, 2026 13:14

dwesolow reviewed Apr 15, 2026

View reviewed changes

jpggvilaca approved these changes Apr 15, 2026

View reviewed changes

camiloHimura added this pull request to the merge queue Apr 15, 2026

Merged via the queue into develop with commit 10dd0b0 Apr 15, 2026
37 checks passed

camiloHimura deleted the ccolora11/5903-number-annotated-frames branch April 15, 2026 15:07


		import { InfiniteData, QueryClient } from '@tanstack/react-query';

		import { SchemaMediaWithPagination } from '../../api/openapi-spec';

Conversation

camiloHimura commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

How to test

Checklist

Uh oh!

github-actions bot commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🐳 Docker image sizes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Test coverage report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

camiloHimura commented Apr 10, 2026 •

edited

Loading

github-actions bot commented Apr 10, 2026 •

edited

Loading

github-actions bot commented Apr 10, 2026 •

edited

Loading