fix: Don't display preview annotations from previous media on the next one#6068
Merged
fix: Don't display preview annotations from previous media on the next one#6068
Conversation
🐳 Docker image sizes
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a race condition in the Segment Anything tool where preview annotations from a previous media item could be applied to the next one by ensuring cancellation is tied to the correct AbortController instance, and adds unit tests to validate cancellation behavior.
Changes:
- Update
useWithCancelto capture the per-invocationAbortControllerand use it for abort checks. - Add Vitest coverage for
useWithCancel(cancel, superseded calls, unmount cleanup). - Refactor mocks to introduce
getMockedShapeand adjust preview update promise handling.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| application/ui/src/features/annotator/tools/segment-anything-tool/use-with-cancel.ts | Fixes abort-controller closure/race by checking the correct controller instance; adjusts hook dependencies. |
| application/ui/src/features/annotator/tools/segment-anything-tool/use-with-cancel.test.ts | Adds unit tests covering cancellation and superseded-call behavior. |
| application/ui/src/features/annotator/tools/segment-anything-tool/segment-anything-tool.component.tsx | Adds a .catch to prevent rejected promises from bubbling during preview updates. |
| application/ui/mocks/mock-annotation.ts | Adds getMockedShape helper and reuses it in getMockedAnnotation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📊 Test coverage report
|
camiloHimura
reviewed
Apr 9, 2026
| setPreviewShapes(shapes.map((shape) => removeOffLimitPoints(shape, roi))); | ||
| }) | ||
| .catch(() => { | ||
| return []; |
Contributor
There was a problem hiding this comment.
Should it clear the current setPreviewShapes?
Contributor
Author
There was a problem hiding this comment.
No, it shouldn't. It would cause flickering previews (like a disco mode).
jpggvilaca
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The issue was caused by incorrect
AbortControllerinstance inside the main function (race conditions/closures).This PR fixes that and adds unit tests.
How to test
Checklist