Conversation
🐳 Docker image sizes
|
📊 Test coverage report
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses multiple UX/data consistency issues in the Models screen by improving variant rendering stability, adding a dataset-based sorting option (and aligning sort options with the chosen grouping mode), and refreshing model data when quantization completes.
Changes:
- Fix React key collisions in the model variant table to prevent duplicated/mis-rendered quantized variants.
- Add
datasetas a new sort mode and adjust group-by/sort-by interactions (dataset vs architecture) with expanded unit tests. - Invalidate/refetch model details when a quantization job finishes (via SSE close) and hide performance badges when no performance category is available.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| application/ui/src/hooks/api/jobs/jobs.hook.ts | Track quantize job model id during SSE updates and invalidate the model details query on close. |
| application/ui/src/features/models/model-listing/utils/sorting.ts | Add dataset sort option and update sort helper signature to accept dataset revisions. |
| application/ui/src/features/models/model-listing/utils/sorting.test.ts | Expand sorting test coverage across all sort modes, including the new dataset sorting. |
| application/ui/src/features/models/model-listing/utils/model-transforms.ts | Plumb dataset revisions through grouped sorting so dataset sort can resolve names. |
| application/ui/src/features/models/model-listing/types.ts | Extend SortBy union with 'dataset'. |
| application/ui/src/features/models/model-listing/provider/model-listing-provider.tsx | Auto-switch sort mode when changing grouping to keep the “other” dimension sortable. |
| application/ui/src/features/models/model-listing/model-variants/quantization-dialog/quantization-dialog.component.tsx | Formatting-only change. |
| application/ui/src/features/models/model-listing/model-variants/model-variant-table.component.tsx | Use stable variant.id as React row key to avoid collisions. |
| application/ui/src/features/models/model-listing/hooks/use-grouped-models.hook.ts | Pass dataset revisions into grouped sorting. |
| application/ui/src/features/models/model-listing/components/models-table-header.component.tsx | Update sorted-state logic for the dataset/architecture column. |
| application/ui/src/features/models/model-listing/components/header.component.tsx | Conditionally show “Sort: Dataset” vs “Sort: Architecture” based on current grouping. |
| application/ui/src/features/models/model-listing/components/group-headers/architecture-group-header.component.tsx | Replace the inline badge with PerformanceCategoryBadge and suppress it when missing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Copilot stopped work on behalf of
dwesolow due to an error
April 9, 2026 11:29
camiloHimura
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How to test
Checklist