Skip to content

fix: A few fixes in models screen#6061

Merged
dwesolow merged 5 commits intodevelopfrom
dwesolow/fix-models
Apr 13, 2026
Merged

fix: A few fixes in models screen#6061
dwesolow merged 5 commits intodevelopfrom
dwesolow/fix-models

Conversation

@dwesolow
Copy link
Copy Markdown
Contributor

@dwesolow dwesolow commented Apr 9, 2026

Summary

  1. Fix displaying more than one row of int 8 quantized model.
  2. Refetch model with new variants when quantization job finishes.
  3. In group by architecture display sorting by dataset, in group by dataset display sorting by architecture.
  4. Don't display model performance badge when there is no performance.
  5. Add more tests for model sorting.

How to test

Checklist

  • The PR title and description are clear and descriptive
  • I have manually tested the changes
  • All changes are covered by automated tests
  • All related issues are linked to this PR (if applicable)
  • Documentation has been updated (if applicable)

@dwesolow dwesolow self-assigned this Apr 9, 2026
@dwesolow dwesolow requested a review from a team as a code owner April 9, 2026 10:29
Copilot AI review requested due to automatic review settings April 9, 2026 10:29
@github-actions github-actions Bot added the Geti UI Issues related to Geti application frontend label Apr 9, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2026

🐳 Docker image sizes

Device Size
cpu 3584.3 MB (3.50 GB)
xpu 10553.0 MB (10.31 GB)
cuda 11715.5 MB (11.44 GB)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2026

📊 Test coverage report

Metric Coverage
Lines 56.3%
Functions 78.3%
Branches 87.3%
Statements 56.3%

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses multiple UX/data consistency issues in the Models screen by improving variant rendering stability, adding a dataset-based sorting option (and aligning sort options with the chosen grouping mode), and refreshing model data when quantization completes.

Changes:

  • Fix React key collisions in the model variant table to prevent duplicated/mis-rendered quantized variants.
  • Add dataset as a new sort mode and adjust group-by/sort-by interactions (dataset vs architecture) with expanded unit tests.
  • Invalidate/refetch model details when a quantization job finishes (via SSE close) and hide performance badges when no performance category is available.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
application/ui/src/hooks/api/jobs/jobs.hook.ts Track quantize job model id during SSE updates and invalidate the model details query on close.
application/ui/src/features/models/model-listing/utils/sorting.ts Add dataset sort option and update sort helper signature to accept dataset revisions.
application/ui/src/features/models/model-listing/utils/sorting.test.ts Expand sorting test coverage across all sort modes, including the new dataset sorting.
application/ui/src/features/models/model-listing/utils/model-transforms.ts Plumb dataset revisions through grouped sorting so dataset sort can resolve names.
application/ui/src/features/models/model-listing/types.ts Extend SortBy union with 'dataset'.
application/ui/src/features/models/model-listing/provider/model-listing-provider.tsx Auto-switch sort mode when changing grouping to keep the “other” dimension sortable.
application/ui/src/features/models/model-listing/model-variants/quantization-dialog/quantization-dialog.component.tsx Formatting-only change.
application/ui/src/features/models/model-listing/model-variants/model-variant-table.component.tsx Use stable variant.id as React row key to avoid collisions.
application/ui/src/features/models/model-listing/hooks/use-grouped-models.hook.ts Pass dataset revisions into grouped sorting.
application/ui/src/features/models/model-listing/components/models-table-header.component.tsx Update sorted-state logic for the dataset/architecture column.
application/ui/src/features/models/model-listing/components/header.component.tsx Conditionally show “Sort: Dataset” vs “Sort: Architecture” based on current grouping.
application/ui/src/features/models/model-listing/components/group-headers/architecture-group-header.component.tsx Replace the inline badge with PerformanceCategoryBadge and suppress it when missing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread application/ui/src/hooks/api/jobs/jobs.hook.ts
@dwesolow dwesolow added this pull request to the merge queue Apr 13, 2026
Merged via the queue into develop with commit a75879c Apr 13, 2026
37 of 38 checks passed
@dwesolow dwesolow deleted the dwesolow/fix-models branch April 13, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Geti UI Issues related to Geti application frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants