Introduce datumaro integration tests for Geti Sample types#6053
Merged
Introduce datumaro integration tests for Geti Sample types#6053
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new backend test suite intended to catch regressions in Datumaro import + schema conversion against pre-collected “real” datasets, and wires it into CI so failures surface early when sample schemas or experimental Datumaro logic drift.
Changes:
- Added
tests/datumaro_integrationpytest suite that downloads a regression dataset bundle and validatesimport_dataset()+convert_to_schema()for supported sample types. - Added a
just test-datumaro-integrationtarget and executed it in the backend CI workflow. - Updated
uv.lock(Datumaro git revision and related wheel URL entries).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
application/backend/tests/datumaro_integration/test_datasets.py |
New smoke test covering import + schema conversion per archive type. |
application/backend/tests/datumaro_integration/conftest.py |
Downloads/extracts regression archives and parametrizes tests over them. |
application/backend/Justfile |
Adds a dedicated command to run the new test suite (and tweaks BDD invocation verbosity/path). |
.github/workflows/backend-lint-and-test.yaml |
Runs Datumaro integration tests as part of backend CI. |
application/backend/uv.lock |
Moves pinned Datumaro revision and updates some locked artifact URLs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🐳 Docker image sizes
|
📊 Test coverage report
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
leoll2
reviewed
Apr 11, 2026
AlbertvanHouten
previously approved these changes
Apr 13, 2026
56fd33f to
d826019
Compare
leoll2
reviewed
Apr 13, 2026
leoll2
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The goal of this PR is to be more proactive when detecting regressions related to datumaro integration.
New test suite will be executed on pre-collected datasets that cover all supported formats and App Sample types.
The failures will indicate either the issues in experimental datumaro logic (
import_dataset+convert_schema) or the outdated App sample type definitions.No job orchestration involved (this is covered in BDD)
Let's merge after experimental API will be healthy:
Checklist