Skip to content

only apply QT_QPA_PLATFORMTHEME to cosmic desktop#262

Merged
24apricots merged 1 commit intomainfrom
theme
Apr 15, 2026
Merged

only apply QT_QPA_PLATFORMTHEME to cosmic desktop#262
24apricots merged 1 commit intomainfrom
theme

Conversation

@danxliu
Copy link
Copy Markdown
Contributor

@danxliu danxliu commented Apr 15, 2026

Fixes issues with this being set on KDE which prevents theming to work properly.

@danxliu danxliu marked this pull request as ready for review April 15, 2026 22:52
Copy link
Copy Markdown
Member

@chamburr chamburr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm(ythos)

Copy link
Copy Markdown

@sawansri sawansri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
-- mythos 6.7

@24apricots
Copy link
Copy Markdown
Member

i was reviewing this and im concerned that this is run before XDG_CURRENT_DESKTOP is set. has this been tested?

@danxliu
Copy link
Copy Markdown
Contributor Author

danxliu commented Apr 15, 2026

i was reviewing this and im concerned that this is run before XDG_CURRENT_DESKTOP is set. has this been tested?

yes i tested, works on cosmic and nicks config is fixed

@24apricots
Copy link
Copy Markdown
Member

ok cool

@24apricots 24apricots merged commit 56e5231 into main Apr 15, 2026
5 checks passed
@24apricots 24apricots deleted the theme branch April 15, 2026 22:56
@danxliu danxliu requested a review from sawansri April 15, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants