fix(optimiser): handle venues with missing coordinates#4378
Open
thejus03 wants to merge 2 commits intonusmodifications:masterfrom
Open
fix(optimiser): handle venues with missing coordinates#4378thejus03 wants to merge 2 commits intonusmodifications:masterfrom
thejus03 wants to merge 2 commits intonusmodifications:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4378 +/- ##
==========================================
+ Coverage 54.52% 56.39% +1.87%
==========================================
Files 274 308 +34
Lines 6076 6963 +887
Branches 1455 1680 +225
==========================================
+ Hits 3313 3927 +614
- Misses 2763 3036 +273 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@thejus03 is attempting to deploy a commit to the modsbot's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
venues.jsonthat exist but have missing/zero coordinates (x=0 or y=0)InvalidCoordinates, preventing incorrect distance calculations in the optimiserCloses #4377
🤖 Generated with Claude Code