Skip to content

fix(optimiser): handle venues with missing coordinates#4378

Open
thejus03 wants to merge 2 commits intonusmodifications:masterfrom
thejus03:bug/venues-without-locations
Open

fix(optimiser): handle venues with missing coordinates#4378
thejus03 wants to merge 2 commits intonusmodifications:masterfrom
thejus03:bug/venues-without-locations

Conversation

@thejus03
Copy link
Copy Markdown
Contributor

Summary

  • Adds a check for venues in venues.json that exist but have missing/zero coordinates (x=0 or y=0)
  • These venues are now treated the same as unknown venues by assigning InvalidCoordinates, preventing incorrect distance calculations in the optimiser

Closes #4377

🤖 Generated with Claude Code

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.39%. Comparing base (988c6fd) to head (8f95f1e).
⚠️ Report is 220 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4378      +/-   ##
==========================================
+ Coverage   54.52%   56.39%   +1.87%     
==========================================
  Files         274      308      +34     
  Lines        6076     6963     +887     
  Branches     1455     1680     +225     
==========================================
+ Hits         3313     3927     +614     
- Misses       2763     3036     +273     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 25, 2026

@thejus03 is attempting to deploy a commit to the modsbot's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimiser does wrong distance computation for venues with no locations

1 participant