This repository was archived by the owner on Jan 15, 2022. It is now read-only.
Load the key file once per Ssh#16
Open
papaben wants to merge 1 commit intonovus:masterfrom
papaben:load-ssh-key-once
Open
Load the key file once per Ssh#16papaben wants to merge 1 commit intonovus:masterfrom papaben:load-ssh-key-once
papaben wants to merge 1 commit intonovus:masterfrom
papaben:load-ssh-key-once
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I separated out the logic of attaching the authentication method for SSH into the individual case classes and extracted the steps necessary to load the key file only once. So that subsequent ssh calls can rely on the same key file.
Let me know if you're unhappy with any of the implementation and I can make changes if desired.