fs: validate position argument before length === 0 early return#62674
fs: validate position argument before length === 0 early return#62674geeksilva97 wants to merge 1 commit intonodejs:mainfrom
Conversation
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62674 +/- ##
==========================================
+ Coverage 89.77% 89.80% +0.03%
==========================================
Files 673 699 +26
Lines 203820 216235 +12415
Branches 39175 41331 +2156
==========================================
+ Hits 182987 194199 +11212
- Misses 13152 14148 +996
- Partials 7681 7888 +207
π New features to boost your workflow:
|
|
Moving One question on the validation ordering: Previously, On the new test cases: The tests with empty buffer and an invalid position object are good β but note that |
Move position validation upwards to match documented behavior.
Fixes #62638