feat: lock screen screenshot background and transitions#2342
Open
RainAfterDark wants to merge 4 commits intonoctalia-dev:mainfrom
Open
feat: lock screen screenshot background and transitions#2342RainAfterDark wants to merge 4 commits intonoctalia-dev:mainfrom
RainAfterDark wants to merge 4 commits intonoctalia-dev:mainfrom
Conversation
|
Hi @RainAfterDark iwas wondering something about the lock screen |
Author
It's in the settings Lock Screen > Appearance > Random passsword icons |
- additionally add python3 and lefthook install shellHook in shell.nix
b2d7440 to
e0c06f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull Request
Motivation
This adds a setting to use a screenshot of the desktop as a background of the lock screen, with just ScreencopyView. I've also added a fade in/out transition for the lock screen, enabled with the lock screen animations setting.
Only tested in Niri so far. There is a bug, where the very first time the lock screen is invoked,ScreencopyView.hasContentis false, because theWlSessionLockSurface.screenseems to be null just before the lock. I've tried not using loaders inLockScreen.qmlbut the issue persists. I'm not sure if this is just an issue with Niri or with quickshell. Other than the first lock, it works as expected.EDIT: Improved implementation on SCVs using grabToImage should resolve this particular bug.
Type of Change
Related Issue
Testing
Describe how you tested your changes and mark the relevant items.
Screenshots / Videos
2026.03.29.16.12.10_00m01s133ms-00m06s883ms.mp4
Checklist
Additional Notes
shell.nixto addpython3as a package for the lefthook script, and a shellHook to install the hooks when entering the dev shell.