Add github action to shellcheck master on push and PRs#3550
Draft
yarikoptic wants to merge 3 commits intonipy:masterfrom
Draft
Add github action to shellcheck master on push and PRs#3550yarikoptic wants to merge 3 commits intonipy:masterfrom
yarikoptic wants to merge 3 commits intonipy:masterfrom
Conversation
yarikoptic
added a commit
to yarikoptic/improveit
that referenced
this pull request
Mar 9, 2023
Demo run effect - nipy/nipype#3550
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3550 +/- ##
=======================================
Coverage 72.85% 72.85%
=======================================
Files 1279 1279
Lines 59322 59322
=======================================
Hits 43220 43220
Misses 16102 16102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
effigies
force-pushed
the
enh-shellcheck
branch
from
06c73e0 to
c319835
Compare
Member
|
@yarikoptic Reran so you can check the output. |
effigies
force-pushed
the
enh-shellcheck
branch
from
c319835 to
b33f61a
Compare
git grep -l '^#\( *shellcheck \|!\(/bin/\|/usr/bin/env \)\(sh\|bash\|dash\|ksh\)\)' \
| xargs shellcheck -f diff
| git apply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it will fail with good number of errors etc to fix up. Let's see if workflow works and shows them.