feat: add code blocks with syntax highlighting#143
Conversation
7fa0207 to
6fe85de
Compare
c3936a9 to
9057ced
Compare
9057ced to
5b7602a
Compare
|
Hi @iamanaws and thank you for the pull request. This will be a useful feature. Just one question: Instead of having two icons for code in the toolbar, I'm wondering if its better to just switch the original "code"icon to add a "code-block". The original "code" doesn't seem that useful, and we can leave the markdown shortcut of "`" if someone wants to use it. Other than that, I will need to test more when I have time, but it looks good so far. |
a518f67 to
4851725
Compare
@nienow sure, it's done! take your time, thanks |
|
what is the reason for the 5000 length limit for using code highlighting? Were you seeing any performance issues? |
I haven't done deep testing, but it has been a problem with other plugins in the past, so I'm just trying to prevent it.
|
|
I did some quick performance testing, and it does slow down around 30000 characters for me on my desktop, so I think 5000 is appropriate to account for slower devices. I will merge and we can always improve it later. Thanks again. |
No description provided.