Conversation
…roperties Agent-Logs-Url: https://github.com/nicklockwood/SwiftFormat/sessions/7065f854-631d-4777-9bb4-27f212330648 Co-authored-by: calda <1811727+calda@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix redundantEquatable to preserve manual equality implementation
Fix Apr 13, 2026
redundantEquatable removing manual == for types with Any.Type stored properties
calda
approved these changes
Apr 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2503 +/- ##
========================================
Coverage 95.31% 95.32%
========================================
Files 168 168
Lines 25410 25410
========================================
+ Hits 24219 24221 +2
+ Misses 1191 1189 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any.Typeis a metatype with==defined for pointer identity but does not conform toEquatable, so the compiler cannot synthesizeEquatablefor types with such properties. The rule was incorrectly treating these as eligible for synthesis.Changes
Sources/Rules/RedundantEquatable.swift: Added"Any.Type"toknownNonEquatableTypesalongside the existing"AnyClass"entryTests/Rules/RedundantEquatableTests.swift: AddedtestPreserveCustomEquatableImplementationComparingAnyTypeExample