Improve inheritance of MultiBody constraints

[tobolar]

Refs #3739

The intension is to rearrange PR #4091 in smaller and better evaluable portions in order to implement "selective model extension" approach after that, see also #4091 (comment)

More PRs will follow.

(This PR is generated by cherry-picking and squashing some comments of #4091 - so no new stuff here.)

[HansOlsson]

Ah, I was a bit confused at first.
This is just normal code refactoring without selective model extension, right?

(But preparing for possibly using it.)

[tobolar]

This is just normal code refactoring without selective model extension, right?

Exactly! This is a pre-step to #4231 to make some meaningful changes from PR #4091 first (which I've changed to a draft and shall be refused later on). Doing that, this PR can be merged to the new MSL version independently of "selective model extension" progress in #4231.

#4228 is of the same idea.

Sorry for the confusion.

[HansOlsson]

Looks ok. Will just run the tests as well to confirm.

[HansOlsson]

Looks good, including tests.

[arunkumar-narasimhan]

@MartinOtter , could you please review this PR?

[tobolar]

@MartinOtter , could you please review this PR?

IMO @beutlich could also do. See his comment #4091 (review) which refers to changes related MBS constraints (which this PR is about). So he is informed as well.

[AHaumer]

@MartinOtter and @HansOlsson please review and finalize this PR, otherwise agree with @tobolar on shifting the milestone.
Feel free to invite additional reviewers.

[coderabbitai]

Warning

Rate limit exceeded

@beutlich has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 35 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between be949b2 and 38ec62b.

📒 Files selected for processing (6)

• Modelica/Mechanics/MultiBody/Interfaces/PartialConstraint.mo (1 hunks)
• Modelica/Mechanics/MultiBody/Interfaces/package.order (1 hunks)
• Modelica/Mechanics/MultiBody/Joints/Constraints/Prismatic.mo (1 hunks)
• Modelica/Mechanics/MultiBody/Joints/Constraints/Revolute.mo (4 hunks)
• Modelica/Mechanics/MultiBody/Joints/Constraints/Spherical.mo (3 hunks)
• Modelica/Mechanics/MultiBody/Joints/Constraints/Universal.mo (1 hunks)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.