Open
Conversation
henrikt-ma
reviewed
Mar 10, 2026
henrikt-ma
reviewed
Mar 10, 2026
Collaborator
henrikt-ma
left a comment
henrikt-ma
left a comment
There was a problem hiding this comment.
I am leaving it for @qlambert-pro to provide a review with approval.
Collaborator
Author
Pinging @qlambert-pro |
qlambert-pro
reviewed
Apr 9, 2026
| In the modification, all input parameters are used to set the corresponding record variables. | ||
|
|
||
| A record constructor can only be called if the referenced record class is found in the global scope, and thus cannot be modified. | ||
| The record constructor can be used in vectorized form according to \cref{scalar-functions-applied-to-array-arguments}. |
Collaborator
There was a problem hiding this comment.
We need to address the record constructor of operator record. Since nothing is said of the conflict it could create.
Collaborator
Author
There was a problem hiding this comment.
An operator record shouldn't have an automatically generated record constructor, as that would cause conflicts with the defined operator record constructors, so their shouldn't be any conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3820
I think this covers all of the discussed cases.
As far as I can see it is also consistent with the previous intent, but just missed: