fix: null dereference in get_SelectionContainer when no selection container exists#16091
Open
fix: null dereference in get_SelectionContainer when no selection container exists#16091
Conversation
Agent-Logs-Url: https://github.com/microsoft/react-native-windows/sessions/dee66731-6253-459a-8ba1-f733d5bee554 Co-authored-by: vineethkuttan <66076509+vineethkuttan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
vineethkuttan
May 6, 2026 14:32
View session
acoates-ms
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Why
get_SelectionContainer(UIASelectionItemPattern.SelectionContainer) crashes with a null dereference when the element has no ancestor with a selection container.GetSelectionContainer()walks the parent tree looking for a view withmultiselectableandrequiredprops set; if none is found it returnsnullptr, which was immediately dereferenced on the next line.What
GetSelectionContainer()inget_SelectionContainerS_OKwith*pRetVal == nullptrwhen no container is found — correct per UIA spec (element is simply not inside a selection container)Screenshots
N/A
Testing
Reproduced by calling
get_SelectionContaineron a selection item whose ancestor tree contains no multiselectable container. Verified the null check prevents the crash and returnsS_OKwith a null provider pointer.Changelog
Should this change be included in the release notes: yes
Fix crash (null dereference) in UIA
SelectionItemPattern.get_SelectionContainerwhen the element has no selection container ancestor.Microsoft Reviewers: Open in CodeFlow