fix: set CsvConverter priority to 5.0 to fix charset detection#1742
Open
Jah-yee wants to merge 2 commits intomicrosoft:mainfrom
Open
fix: set CsvConverter priority to 5.0 to fix charset detection#1742Jah-yee wants to merge 2 commits intomicrosoft:mainfrom
Jah-yee wants to merge 2 commits intomicrosoft:mainfrom
Conversation
added 2 commits
April 13, 2026 20:37
This fix extends YouTubeConverter.accepts() to recognize: - https://youtu.be/<id> short URLs - https://www.youtube.com/shorts/<id> URLs Also adds _extract_video_id() helper to extract video ID from all URL formats for transcript fetching. Fixes: microsoft#1730
CsvConverter was using default priority (10.0), which caused it to be tried after PlainTextConverter. Since PlainTextConverter accepts text/* mimetypes and CsvConverter uses text/csv, the CSV file was incorrectly handled as plain text when the charset was detected by magika. This fix sets CsvConverter priority to 5.0, placing it before PlainTextConverter (priority 10.0) in the converter chain, ensuring CSV files are properly converted to Markdown tables. Fixes test failure: hatch test fail with: The formats ['.csv'] are not supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
This PR fixes the CSV file charset detection issue where CSV files with non-UTF-8 charset (like cp932 encoding) were not being handled correctly.
Root Cause:
Solution:
Set CsvConverter priority to 5.0, placing it before PlainTextConverter (priority 10.0) in the converter chain.
Testing:
感谢你们的奉献，希望能提供帮助。如果我解决得有问题或有待商妥的地方，请在下面留言，我会来处理。
Warmly,
RoomWithOutRoof