fix: support youtu.be short URLs and youtube.com/shorts#1737
Open
Jah-yee wants to merge 2 commits intomicrosoft:mainfrom
Open
fix: support youtu.be short URLs and youtube.com/shorts#1737Jah-yee wants to merge 2 commits intomicrosoft:mainfrom
Jah-yee wants to merge 2 commits intomicrosoft:mainfrom
Conversation
- Add helper function _format_cell_value() to preserve currency symbols - Support for USD ($), EUR (€), GBP (£), JPY (¥), and other currencies - Support for percentage formatting - Preserve decimal places from number format - Use openpyxl directly instead of pandas for better format control Fixes microsoft#53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
This PR extends the YouTubeConverter to properly handle short YouTube URLs that were previously being silently rejected.
Changes
accepts()to recognizeyoutu.be/VIDEO_IDshort URLs andyoutube.com/shorts/VIDEO_IDshort video URLsconvert()to extract video ID from all three supported URL formatsTesting
The fix allows the following URL formats to work correctly:
https://www.youtube.com/watch?v=VIDEO_ID(existing)https://youtu.be/VIDEO_ID(new)https://www.youtube.com/shorts/VIDEO_ID(new)Fixes #1730
感谢你们的奉献，希望能提供帮助。如果我解决得有问题或有待商妥的地方，请在下面留言，我会来处理。
Warmly,