Fix bare except blocks that silently swallow all errors#388
Open
hobostay wants to merge 1 commit into
Open
Conversation
Replace `except Exception: pass` with `except ValueError: pass` in vLLM plugin registration. The broad Exception handler hides real errors like TypeError or AttributeError that indicate a genuine bug (e.g., wrong argument types), not just "already registered". The transformers registry raises ValueError when a config class is already registered, so catching ValueError is sufficient. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
except Exception: passwithexcept ValueError: passin the vLLM plugin registration codeExceptionhandler hides real bugs (TypeError, AttributeError, etc.) that indicate a genuine problem, not just "already registered"ValueErrorwhen a config class is already registered, so catchingValueErroris sufficientDetails
Affected file:
vllm_plugin/__init__.py(lines 40-53)If the registration fails for a reason other than "already registered" (e.g., wrong argument types, missing attributes), the error would be silently swallowed and the model would malfunction later with no indication of the root cause.
Test plan
🤖 Generated with Claude Code