fix: sanitize subprocess call in start_server.py#371
Open
orbisai0security wants to merge 1 commit into
Open
Conversation
At start_server Resolves V-001
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
vllm_plugin/scripts/start_server.py.Vulnerability
V-001vllm_plugin/scripts/start_server.py:35Description: At start_server.py line 35, subprocess.run is called with shell=True, causing the entire cmd string to be passed to /bin/sh for interpretation. The cmd variable is constructed from CLI arguments and configuration values. Any shell metacharacters present in cmd (e.g., semicolons, backticks, pipe characters, dollar signs) will be executed as separate shell commands. If any portion of cmd originates from user-controlled input such as CLI arguments, environment variables, or writable configuration files, an attacker can inject arbitrary OS commands that execute with the full privileges of the server process.
Changes
vllm_plugin/scripts/start_server.pyVerification
Automated security fix by OrbisAI Security