Candidate fix for #2434#2447
Open
willend wants to merge 1 commit intomccode-dev:mainfrom
Open
Conversation
Contributor
Author
|
This instrument includes component names of box and sphere and parses/renders correctly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Free-form text area
Please describe what your PR is adding in terms of features or bugfixes:
This PR includes a simple approach to fixing #2434 composed of 2 elements:
instrparser.pyto include anmcdisprefixmccode-r.cto patch the geometry printing routines to include this prefixI have further removed unsused tokens from
instrparser.py———————
Development OS / boundary conditions
Please describe what OS you developed and tested your additions on, and if any special dependencies are required:
———————
PR Checklist for contributing to McStas/McXtrace
For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:
My contribution contains something else
———————