mate-screenshot: Fix area selection timing with keyboard shortcuts#377
Open
mate-screenshot: Fix area selection timing with keyboard shortcuts#377
Conversation
Member
|
As the hack already exists why not, but I'd rather see that on the other side of things, that is on the keybinding handlers or simply the commands themselves (I personally used something like |
This prevents possible race conditions when launched via keyboard shortcuts. The delay allows keyboard handlers to release before input grabbing begins. Fixes #37
84f5143 to
7914c08
Compare
Member
Author
|
@cwendling good point, but fixing the at the keybinding handler level seems like would bring up some edge cases I'm not sure I want to test :P For now, I changed this commit to be more specifically targetted to area screenshots, and leave the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents possible race conditions when launched via keyboard shortcuts. The delay allows keyboard handlers to release before input grabbing begins.