feat(plotly): add reactive funnel, funnelarea and strip selection support by axsseldz · Pull Request #9044 · marimo-team/marimo

axsseldz · 2026-04-04T02:22:04Z

📝 Summary

Adds click-based selection support for funnel and funnelarea Plotly trace types, making them fully reactive in mo.ui.plotly.

🔍 Description of Changes

Frontend: shouldHandleClickSelection now handles "funnel" and "funnelarea" clicks; extractPoints returns trace-appropriate fields (x, y, label, value, percentages for funnel; label, value, percentages for funnelarea — no x/y)
Backend: _convert_value dispatches to _append_funnel_points_to_selection and _append_funnelarea_points_to_selection; range selections extract stages by value overlap; click selections pass through with index resync
Example: examples/third_party/plotly/funnel_chart.py with px.funnel, multi-trace regional funnel, and go.Funnelarea

Selection

📋 Pre-Review Checklist

For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
Any AI generated code has been reviewed line-by-line by the human PR author, who stands by it.
Video or media evidence is provided for any visual changes (optional).

✅ Merge Checklist

I have read the contributor guidelines.
Documentation has been updated where applicable, including docstrings for API changes.
Tests have been added for the changes made.

@mscolnick @nojaf

vercel · 2026-04-04T02:22:10Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
marimo-docs	Ready	Preview, Comment	Apr 13, 2026 2:31am

Copilot

Pull request overview

Adds reactive selection support for Plotly funnel and funnelarea traces in mo.ui.plotly, extending both frontend click-payload extraction and backend selection conversion so these chart types behave like other reactive Plotly traces.

Changes:

Frontend: Treat funnel/funnelarea as click-selectable trace types and extract trace-specific fields from click payloads.
Backend: Convert selections for funnel (range + click cleanup) and funnelarea (click cleanup + index resync).
Tests/docs/examples: Add coverage, update docs, and introduce a new funnel selection example.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`tests/_plugins/ui/_impl/test_plotly.py`	Adds backend tests for funnel/funnelarea click and range selection behavior.
`marimo/_plugins/ui/_impl/plotly.py`	Implements funnel range extraction + click cleanup; adds funnelarea click cleanup.
`frontend/src/plugins/impl/plotly/selection.ts`	Adds click selection handling and key extraction for funnel/funnelarea click payloads.
`frontend/src/plugins/impl/plotly/__tests__/selection.test.ts`	Adds frontend unit tests for funnel/funnelarea click handling + extracted fields.
`examples/third_party/plotly/funnel_chart.py`	New example demonstrating reactive funnel and funnelarea selections.
`docs/api/plotting.md`	Updates docs to list funnel charts as supported for reactive selection.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

mscolnick · 2026-04-06T19:48:45Z

@axsseldz sorry looks like there are some merge conflicts again. if there are more, feel free to group some of these PRs together and branch them on top of each other

axsseldz · 2026-04-06T21:05:05Z

@axsseldz sorry looks like there are some merge conflicts again. if there are more, feel free to group some of these PRs together and branch them on top of each other

yeap, i'll take a look, ill let you know once its done, tyy!

Resolves conflicts between waterfall (merged to main) and strip/box/violin additions. Both feature sets are now present: waterfall handlers are inserted before the box/violin handlers in _convert_value, and all function definitions are included. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Resolves conflicts between waterfall (merged to main) and funnel additions. Both feature sets included: waterfall handlers inserted before funnel handlers in _convert_value, all function definitions and tests from both branches kept. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Fix unsafe np.asarray(val_data, dtype=np.float64) call: wrap in try/except and fall back to element-wise extraction when val_data contains None or non-numeric entries (comment 1) - Fix off-by-one in overlap check: use >= val_min (inclusive lower bound) in both the numpy fast path and the pure-Python fallback, consistent with bar selection behavior (comment 2) - Correct docstring: click path strips empty placeholders and re-syncs indices; it does not deduplicate (comment 3) - Update docs to mention funnelarea support explicitly (comment 4) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

axsseldz · 2026-04-08T09:18:28Z

@axsseldz sorry looks like there are some merge conflicts again. if there are more, feel free to group some of these PRs together and branch them on top of each other

hey @mscolnick i think this PR and (#9012) had similar merge conflicts so i just updated both of them, either way if i keep getting these merge conflicts ill stack them, but for now both should be fine 👍

Syncs strip chart support into box branch so both can merge into main independently without conflicts. Adds strip chart example, strip test section, and updated supported-charts documentation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Adds funnel/funnelarea chart support from feat/reactive-plotly-funnel so that both branches can merge into main independently without conflicts. Includes funnel/funnelarea trace types, test cases, and docs updates. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

The cross-branch merge left two competing implementations of _append_box_points_to_selection and its helpers, plus duplicate _build_waterfall_point and _append_map_scatter_points_to_selection. Python silently used the last definition; pyright caught all six [no-redef] errors in CI. Removes the dead first copies. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

codecov · 2026-04-11T03:27:10Z

Bundle Report

Changes will increase total bundle size by 12.8kB (0.05%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
marimo-esm	24.84MB	12.8kB (0.05%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: marimo-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/cells-*.js`	384 bytes	703.39kB	0.05%
`assets/index-*.js`	683 bytes	602.15kB	0.11%
`assets/index-*.css`	290 bytes	362.29kB	0.08%
`assets/dist-*.js`	-52 bytes	335 bytes	-13.44%
`assets/dist-*.js`	-234 bytes	169 bytes	-58.06%
`assets/dist-*.js`	-33 bytes	104 bytes	-24.09%
`assets/dist-*.js`	-166 bytes	169 bytes	-49.55%
`assets/dist-*.js`	56 bytes	160 bytes	53.85% ⚠️
`assets/dist-*.js`	6 bytes	183 bytes	3.39%
`assets/dist-*.js`	40 bytes	177 bytes	29.2% ⚠️
`assets/dist-*.js`	283 bytes	387 bytes	272.12% ⚠️
`assets/dist-*.js`	-7 bytes	176 bytes	-3.83%
`assets/dist-*.js`	-5 bytes	164 bytes	-2.96%
`assets/dist-*.js`	87 bytes	256 bytes	51.48% ⚠️
`assets/dist-*.js`	-172 bytes	104 bytes	-62.32%
`assets/dist-*.js`	155 bytes	259 bytes	149.04% ⚠️
`assets/dist-*.js`	-72 bytes	104 bytes	-40.91%
`assets/dist-*.js`	-62 bytes	102 bytes	-37.8%
`assets/dist-*.js`	35 bytes	137 bytes	34.31% ⚠️
`assets/dist-*.js`	17 bytes	276 bytes	6.56% ⚠️
`assets/dist-*.js`	243 bytes	403 bytes	151.88% ⚠️
`assets/dist-*.js`	-119 bytes	137 bytes	-46.48%
`assets/JsonOutput-*.js`	-1 bytes	336.29kB	-0.0%
`assets/edit-*.js`	-42.36kB	329.61kB	-11.39%
`assets/layout-*.js`	56.26kB	185.91kB	43.39% ⚠️
`assets/slides-*.js`	360 bytes	116.37kB	0.31%
`assets/panels-*.js`	-3.15kB	45.36kB	-6.5%
`assets/state-*.js`	192 bytes	24.05kB	0.8%
`assets/RenderHTML-*.js`	60 bytes	5.01kB	1.21%
`assets/ttcn-*.js`	7 bytes	64 bytes	12.28% ⚠️
`assets/ttcn-*.js`	-7 bytes	57 bytes	-10.94%
`assets/button-*.js`	93 bytes	3.93kB	2.43%

Files in assets/index-*.js:

./src/plugins/impl/plotly/selection.ts → Total Size: 7.39kB

Light2Dark · 2026-04-12T15:58:27Z

There's some merge conflicts.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

axsseldz added 2 commits April 3, 2026 16:58

feat(plotly): add reactive strip selection support

d4d23d8

Copilot comments resolved

0891779

Copilot AI review requested due to automatic review settings April 4, 2026 02:22

axsseldz requested review from Light2Dark, akshayka and manzt as code owners April 4, 2026 02:22

github-actions bot added the documentation Improvements or additions to documentation label Apr 4, 2026

Copilot started reviewing on behalf of axsseldz April 4, 2026 02:22 View session

vercel bot deployed to Preview April 4, 2026 02:23 View deployment

Copilot AI reviewed Apr 4, 2026

View reviewed changes

Comment thread marimo/_plugins/ui/_impl/plotly.py

Comment thread marimo/_plugins/ui/_impl/plotly.py

Comment thread marimo/_plugins/ui/_impl/plotly.py Outdated

Comment thread tests/_plugins/ui/_impl/test_plotly.py Outdated

feat(plotly): add reactive funnel selection support

328a547

axsseldz force-pushed the feat/reactive-plotly-funnel branch from 4ca30aa to 328a547 Compare April 4, 2026 03:02

vercel bot deployed to Preview April 4, 2026 03:03 View deployment

mscolnick requested a review from Copilot April 6, 2026 18:59

Copilot started reviewing on behalf of mscolnick April 6, 2026 19:00 View session

Copilot AI reviewed Apr 6, 2026

View reviewed changes

Comment thread marimo/_plugins/ui/_impl/plotly.py Outdated

Comment thread marimo/_plugins/ui/_impl/plotly.py Outdated

Comment thread marimo/_plugins/ui/_impl/plotly.py Outdated

Comment thread docs/api/plotting.md Outdated

axsseldz and others added 9 commits April 7, 2026 23:10

feat(plotly): add reactive box selection support

ed2da21

Copilot comments resolved

d3852fa

refactor(plotly): reduce type assertions in selection.ts

12e7cef

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor(plotly): reduce unnecessary type assertions in selection.ts

dace8ee

refactor(plotly): reduce unnecessary type assertions in selection.ts

99219ff

fix(plotly): fix malformed test structure in selection.test.ts

fead98e

vercel bot deployed to Preview April 8, 2026 08:52 View deployment

axsseldz and others added 8 commits April 8, 2026 09:21

Merge main into feat/reactive-plotly-funnel

0f2f405

fix(plotly): remove duplicate violin check in strip _convert_value

f3e1c0c

fix(plotly): remove duplicate violin tests in strip test file

73c70c9

merge feat/reactive-plotly-funnel into plotly-box for cross-branch sync

3020767

fix(plotly): remove duplicate box/violin test cases in selection.test.ts

4d2ec4c

fix(plotly): remove duplicate box/violin test cases in selection.test.ts

f7e8ae4

vercel bot deployed to Preview April 8, 2026 17:15 View deployment

axsseldz mentioned this pull request Apr 8, 2026

feat(plotly): add reactive box plot selection support #9010

Merged

6 tasks

vercel bot deployed to Preview April 8, 2026 17:25 View deployment

Merge branch 'feat/reactive-plotly-box' into feat/reactive-plotly-funnel

de60f47

axsseldz force-pushed the feat/reactive-plotly-funnel branch from 4e19bcb to de60f47 Compare April 9, 2026 01:40

vercel bot deployed to Preview April 9, 2026 01:42 View deployment

mscolnick requested a review from Copilot April 9, 2026 03:04

Copilot started reviewing on behalf of mscolnick April 9, 2026 03:04 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

Comment thread marimo/_plugins/ui/_impl/plotly.py

Comment thread marimo/_plugins/ui/_impl/plotly.py

Comment thread examples/third_party/plotly/funnel_chart.py Outdated

Merge branch 'main' into feat/reactive-plotly-funnel

f7edf33

vercel bot deployed to Preview April 11, 2026 02:52 View deployment

Light2Dark requested a review from Copilot April 12, 2026 15:57

Copilot started reviewing on behalf of Light2Dark April 12, 2026 15:58 View session

Copilot AI reviewed Apr 12, 2026

View reviewed changes

Comment thread marimo/_plugins/ui/_impl/plotly.py

Comment thread marimo/_plugins/ui/_impl/plotly.py

Merge branch 'main' into feat/reactive-plotly-funnel

197f521

vercel bot deployed to Preview April 13, 2026 02:31 View deployment

Light2Dark approved these changes Apr 13, 2026

View reviewed changes

Light2Dark merged commit b95d26d into marimo-team:main Apr 13, 2026
24 checks passed

axsseldz changed the title ~~feat(plotly): add reactive funnel and funnelarea selection support~~ feat(plotly): add reactive funnel, funnelarea and strip selection support Apr 13, 2026

Conversation

axsseldz commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Summary

🔍 Description of Changes

Selection

📋 Pre-Review Checklist

✅ Merge Checklist

Uh oh!

vercel bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mscolnick commented Apr 6, 2026

Uh oh!

axsseldz commented Apr 6, 2026

Uh oh!

axsseldz commented Apr 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Apr 11, 2026

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

Light2Dark commented Apr 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

axsseldz commented Apr 4, 2026 •

edited

Loading

vercel bot commented Apr 4, 2026 •

edited

Loading