Exercise 3, 4, and 5 completed exercises replaced with correct code#6
Open
smckinney1 wants to merge 3 commits intomarcysutton:mainfrom
Open
Exercise 3, 4, and 5 completed exercises replaced with correct code#6smckinney1 wants to merge 3 commits intomarcysutton:mainfrom
smckinney1 wants to merge 3 commits intomarcysutton:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
smckinney1
changed the title
smckinney1
commented
Jul 2, 2024
This was mostly in line with the video to begin with. The biggest changes are the addition of the ModalHeader and some button alt text.
smckinney1
changed the title
smckinney1
commented
Jul 3, 2024
| <div className="flex max-w-[1400px] mx-auto"> | ||
| <div className="mx-auto md:max-w-[65%] lg:max-w-[70%] flex"> | ||
| <p id="carouselheading" className="sr-only"> | ||
| <p id="carouselheading" className="hidden"> |
Contributor
Author
There was a problem hiding this comment.
Class name should not have switched from sr-only to hidden...not sure if this wasn't covered in the videos & that is how it was missed, or if I neglected to update alongside the video. As mentioned in my updated PR description, I'm having issues with git locally that I don't have time to troubleshoot & am going to leave this alone for now (will also be an issue for the other completed exercise files in this PR).
Contributor
Author
|
OK, as mentioned a couple of times in the updated description & comments, this PR is not perfect, but it does show a bit better the actual changes that were made in each video exercise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exercise 3, exercise 4, and exercise 5 completed code should now be in sync with the end of the "HTML" segment of the Frontend Masters Web Accessibility (v3) course.
There is an issue with the completed exercises in that they contain all of the code for future exercises as well.
Issue reference
update 7/3/24:
I did notice that the unchanged files in each "completed" directory should be in sync with the last completed set of code for that file, but they are not.
I'm having issues with git locally that I don't have time to troubleshoot at the moment and have had to update each file individually on my fork via GitHub.
As such I'm not going to go through all of the other files to keep them up to date.
Right now this PR is solely focused on the files changed in the video for that exercise.