docs(known-issues): track #23478 #17204 #34600 and add Layer 7 YAML syntax check#55
Conversation
…check - Document three newly tracked Claude Code platform bugs affecting VibeGuard: - #23478: paths rules not triggered on Write/Edit (Medium) - #17204: quoted paths values preserved verbatim in glob (Medium) - #34600: exit 2 rendered as "Error" in UI (Low) - Add compliance_check.sh Layer 7: Rule YAML Syntax — detects YAML array syntax and quoted paths in ~/.claude/rules/vibeguard/ automatically - Update summary table and monitoring section with new entries - Update last-updated date to 2026-03-28 Closes #26
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59367349b6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| # Check for quoted paths (bug #17204: quoted values preserved verbatim in glob) | ||
| if command -v rg >/dev/null 2>&1; then | ||
| quoted_files=$(rg -l '^paths:\s+"[^,]+"' "${RULES_DIR}" 2>/dev/null || true) |
There was a problem hiding this comment.
Match quoted CSV paths in Layer 7 check
The quoted_files pattern ^paths:\s+"[^,]+" only matches quoted values that contain no comma, so the common broken form paths: "**/*.ts,**/*.tsx" is not detected and Layer 7 incorrectly reports PASS. This directly defeats the stated purpose of catching bug #17204 and allows misconfigured rules to slip through.
Useful? React with 👍 / 👎.
…hecks Issue 1 (L149/L151): regex `[^,]+` missed quoted CSV paths like `paths: "**/*.ts,**/*.tsx"` — change to `[^"]+` to match any quoted value. Issue 2 (L139): grep fallback used `^\s+-\s+"` (only quoted array items), diverging from rg branch which matched all array items — change to `^\s+-\s+`.
…te paths check - L139 fallback: replace file-level grep AND with awk proximity check so indented Markdown lists elsewhere in a file no longer cause false-positive YAML array detection - L149-151: extend quoted-paths pattern to cover single-quoted paths (paths: '**/*.ts') in addition to double-quoted, both rg and grep paths
|
/gemini review |
Summary
docs/reference/claude-code-known-issues.mdcompliance_check.shLayer 7 that automatically detects broken YAML syntax (paths:array format and quoted values) in~/.claude/rules/vibeguard/Test plan
bash tests/test_hooks.sh— 81/81 passbash tests/test_rust_guards.sh— 4/4 passbash tests/test_precision_tracker.sh— 38/38 passbash tests/test_setup.sh— 34/34 pass[PASS]against current installed rulesCloses #26