Fix page layout xml of pagebuilder overriding the layout set by theme

[GrimLink]

Description (*)

This Pull Request removes the hardcoded layout attribute from Magento/PageBuilder/view/frontend/page_layout/catalog_category_view.xml.

Since the Magento 2.4.6-p3, this attribute forces a specific layout, making it impossible for custom themes to override the category page layout via their own XML files. Removing this attribute restores the expected layout inheritance and allows theme-level overrides to function correctly.

Fixed Issues (if relevant)

1. layout 2 columns left avoid to override layout on catalog_category_view #829: Cannot override category layout in custom theme since 2.4.6-p3
2. page layout xml of pagebuilder override the layout set by theme magento2#38473: Layout set in Magento_PageBuilder overriding layout set by theme

Related Pull Requests

• Layout catalog_category_view - fallback mechanism Fixed #835 (comment)

Manual testing scenarios (*)

1. Install a Magento instance (version 2.4.6-p3 or newer) with PageBuilder enabled.
2. Create or use a custom frontend theme.
3. In the custom theme, create a layout override: app/design/frontend/[Vendor]/[Theme]/Magento_Catalog/layout/catalog_category_view.xml.
4. Define a specific layout in that file (e.g., <page layout="1column" ...>).
5. Flush the cache and view a category page on the storefront.
6. Result (Pre-fix): The category page ignores the theme setting and sticks to the PageBuilder-defined layout.
7. Result (Post-fix): The category page correctly honors the layout defined in the custom theme.

Questions or comments

N/A

Checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[GrimLink]

@magento run all tests

[engcom-Hotel]

Hello @GrimLink,

Thank you for the report and collaboration!

The changes looks good to us, but please cover the changes with some automated test in accordance to the DOD.

Also fix the static test failure.

Thank you

[GrimLink]

@engcom-Hotel, the tests are still failing regardless of this change. It looks like the issue is pre-existing, so I can't fix what was already broken. 😅

[engcom-Hotel]

Hello @GrimLink,

Thank you for your reply!

I know the static test failure is not due to your code changes, they are related to the copyright missing in the XML file updated in this PR.

So you just need to add the below line to fix the static test failure:

/**
* Copyright [year code created] Adobe
* All Rights Reserved.
**/

The other functional test failures are the not related to this PR, so we can skip it for now.

Also please add some automated test in accordance to the DOD.

Thank you

[GrimLink]

@engcom-Hotel Regarding the copyright block: it is present in the file (see below), consistent with the other XML files. However, I’ve updated it to match your suggestion.

<!--
/**
 * Copyright © Magento, Inc. All rights reserved.
 * See COPYING.txt for license details.
 */
-->

Regarding the Definition of Done (DoD): Could you clarify why automated tests are required for this specific change? Since this is a straightforward bug fix for a long-standing issue (dating back to 2022) and doesn't introduce new logic, it seems to fall under the "as applicable" of a DoD. I’d like to ensure we aren’t adding unnecessary test overhead for such a minor correction.

[GrimLink]

@magento run all tests

[engcom-Hotel]

Hello @GrimLink,

Thank you for making the changes to fix the static test failure.

Regarding the Definition of Done (DoD): Could you clarify why automated tests are required for this specific change? Since this is a straightforward bug fix for a long-standing issue (dating back to 2022) and doesn't introduce new logic, it seems to fall under the "as applicable" of a DoD. I’d like to ensure we aren’t adding unnecessary test overhead for such a minor correction.

I agree with your point but I guess a minimal MFTF or integration test that verifies theme-level layout overrides are respected on category pages when PageBuilder is active. This prevents future reintroduction of the bug.

Thank you

[GrimLink]

@magento run all tests

[engcom-Hotel]

Hello @GrimLink,

Thank you for adding the MFTF test. By looking into the functional test failures, it seems the added MFTF is failing.

Please look into it.

Thank you

[GrimLink]

@magento run all tests

[GrimLink]

@engcom-Hotel the test is now green, only one other test is failing which is not related to this PR.