Added Datastore.findOpts(query, opts, callback)#489
Open
iyobo wants to merge 5 commits intolouischatriot:masterfrom
Open
Added Datastore.findOpts(query, opts, callback)#489iyobo wants to merge 5 commits intolouischatriot:masterfrom
iyobo wants to merge 5 commits intolouischatriot:masterfrom
Conversation
- Now considers sort
|
Yes, this make sense. However, I would recommend adding additional options to the standard |
Author
|
The main issue with that is neither count nor findOne are paged or sorted. The criteria should remain seperate from query options. |
|
You may be right. However, I don't think we should add this pull request to the official distribution. I hope @louischatriot will take a clever decision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findOpts is an extended version of the find function, where the 2nd parameter (previously just projections) is now used to pass in fields (aka projections), paging, and sort values which, for the most part, eliminates the need to return a cursor.
This function will never return a cursor and will always expect the last parameter to be a callback, keeping it auto-promisification compliant.
i.e. With this function, you can now run promise.promisifyAll(...) on an instance of Datastore to be able to use await or yield on findOptsAsync with all working find features whereas simply using findAsync function would be severely handicapped as it would not be able to page or sort.