You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't think this is a good way to fix this -- it will prevent people from installing umap if they have the latest version of SciPy. I think @lmcinnes has a fix in master that fixes the error in #39 without pinning a version
@gforsyth Saying this again here (as I did in #39), this PR can stay open until after newer versions of scipy are released. Or it can be closed. Just giving @lmcinnes the option.
I agree with @gforsyth, but I'll just leave this open and pending in case the other fix doesn't seem to take for some reason. Thanks for submitting it -- it's always useful to have a backup option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #39.