Skip to content

Excluded scipy v1.0.0 from setup.py#47

Open
wflynny wants to merge 1 commit intolmcinnes:masterfrom
wflynny:master
Open

Excluded scipy v1.0.0 from setup.py#47
wflynny wants to merge 1 commit intolmcinnes:masterfrom
wflynny:master

Conversation

@wflynny
Copy link
Copy Markdown

@wflynny wflynny commented Feb 21, 2018

See issue #39.

@pep8speaks
Copy link
Copy Markdown

Hello @wflynny! Thanks for submitting the PR.

  • In the file setup.py, following are the PEP8 issues :

Line 3:1: E302 expected 2 blank lines, found 1
Line 7:1: E305 expected 2 blank lines after class or function definition, found 1
Line 8:11: E203 whitespace before ':'
Line 10:18: E203 whitespace before ':'
Line 11:23: E203 whitespace before ':'
Line 12:18: E203 whitespace before ':'
Line 28:15: E203 whitespace before ':'
Line 29:10: E203 whitespace before ':'
Line 30:17: E203 whitespace before ':'
Line 31:23: E203 whitespace before ':'
Line 32:14: E203 whitespace before ':'
Line 33:15: E203 whitespace before ':'
Line 34:23: E203 whitespace before ':'
Line 37:18: E203 whitespace before ':'
Line 38:15: E203 whitespace before ':'
Line 39:17: E203 whitespace before ':'
Line 40:20: E203 whitespace before ':'
Line 41:17: E203 whitespace before ':'

@gforsyth
Copy link
Copy Markdown

I don't think this is a good way to fix this -- it will prevent people from installing umap if they have the latest version of SciPy. I think @lmcinnes has a fix in master that fixes the error in #39 without pinning a version

@wflynny
Copy link
Copy Markdown
Author

wflynny commented Feb 21, 2018

@gforsyth Saying this again here (as I did in #39), this PR can stay open until after newer versions of scipy are released. Or it can be closed. Just giving @lmcinnes the option.

@lmcinnes
Copy link
Copy Markdown
Owner

I agree with @gforsyth, but I'll just leave this open and pending in case the other fix doesn't seem to take for some reason. Thanks for submitting it -- it's always useful to have a backup option.

@sleighsoft
Copy link
Copy Markdown
Collaborator

@lmcinnes Did this get resolved already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants