chore(deps): bump @livepeer/design-system to 1.1.2#622
Open
chore(deps): bump @livepeer/design-system to 1.1.2#622
Conversation
Restores the subdued Button styling (subdued `primary` / `neutral` / color-loop variants, `transparentWhite` / `transparentBlack` variants, base styles) that Explorer has been rendering from the v1.1.0 tarball for ~3 years. v1.1.2 is byte-identical to v1.1.0 for the Button block, so this bump requires zero call-site code changes. Background: the published v1.1.0 tarball contained Button styling that had never existed in any commit of livepeer/design-system — it was built from an uncommitted working tree in 2023 and diverged silently from git main, which used a saturated variant form. Explorer could never upgrade (v1.1.1 shipped with an empty `dist/` folder and is unusable), so the divergence was invisible until someone tried to build Explorer against design-system `main`. v1.1.2 (livepeer/design-system#158) codifies the tarball state as the committed source of truth so the repository and the shipped artifact finally agree. This PR brings Explorer along for the ride. Refs livepeer/design-system#156 Refs livepeer/design-system#158 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Explorer app’s dependency on @livepeer/design-system to the patched 1.1.2 release, aligning with the intended published artifact without requiring any application code changes.
Changes:
- Bump
@livepeer/design-systemfrom1.1.0to1.1.2inpackage.json. - Update
pnpm-lock.yamlto reflect the new@livepeer/design-systemversion and refreshed lock metadata.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Pins @livepeer/design-system to 1.1.2. |
| pnpm-lock.yaml | Updates the resolved @livepeer/design-system entry to 1.1.2 (and lock metadata updates consistent with a re-resolve). |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Strips 60 instances of `onPointerEnterCapture={undefined}`,
`onPointerLeaveCapture={undefined}`, and `placeholder={undefined}`
across 14 files. These were band-aids for a `@types/react@18.x` bug
(DefinitelyTyped#64914) that was fixed upstream 2+ years ago — the
props are now optional everywhere, so passing `undefined` is both
unnecessary and, as of @livepeer/design-system@1.1.2, a type error.
Context: `@livepeer/design-system@1.1.0`'s `Sheet.d.ts` happened to
emit a verbose `Pick<SheetContentProps, "color" | "translate" | ... |
"onPointerEnterCapture" | "onPointerLeaveCapture" | "placeholder" |
...>` form (an artifact of the TypeScript/@types/react combo at its
July 2023 build time). That explicit prop list masked the dead code.
v1.1.2 was rebuilt today with a newer toolchain that emits the cleaner
`Omit<SheetContentProps, "ref">` form, which defers to the current
`@types/react` shape — and the current shape no longer includes those
three props. The latent dead code therefore became a compile error.
Verified clean via `pnpm exec tsc --noEmit` (exit 0, zero errors).
Refs livepeer/design-system#158
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
@livepeer/design-systemfrom1.1.0to1.1.2. Zero code changes — v1.1.2 is byte-identical to the v1.1.0 tarball for the Button block, so no call sites need updating.Background
The
@livepeer/design-system@1.1.0tarball (2023-07-21) was published from a working tree with uncommitted modifications tocomponents/Button.tsx. Its styling — subdued$<c>4+$<c>11variants acrossprimary/neutral/ color-loop,transparentWhite/transparentBlackvariants,fontWeight: 600,cursor: "pointer", specific size radii — has never existed in any commit in livepeer/design-system.mainhas used the saturated$<c>9+ white form since v1.0.17 (April 2023).Explorer pinned
^1.1.0and has rendered that tarball form ever since. v1.1.1 (2024-04-26) shipped with an emptydist/and was unusable, so no consumer could upgrade. For ~3 years the divergence was invisible — until someone tried to build Explorer against design-systemmainand discovered Buttons rendering in a completely different (saturated green) form.livepeer/design-system#158 codifies the v1.1.0 tarball state as committed source so the repository and the shipped artifact finally agree. v1.1.2 is the patch release of that alignment.
Byte-parity guarantee
The
Buttonblock indist/index.jswas verified identical (viaawkblock extraction →diff→ empty) between the published v1.1.0 tarball and v1.1.2 before publishing. Explorer will see zero visual difference on any Button call site.Explorer call-site inventory that was checked (no changes needed to any of these):
variant="primary"— subdued green (fixed CTA look Explorer expects)variant="neutral"— subdued grey (D/W toggle, navigation, etc.)variant="red"oncomponents/account.tsxUndelegate — subdued redvariant="transparentWhite"incomponents/Claim— hsla white overlayvariant="transparentBlack"incomponents/RegisterToVote,components/InactiveWarning— hsla black overlay1through4— pre-divergence radii preservedTest plan
pnpm installcompletes cleanlypnpm dev— homepage D/W toggle renders (W button subdued green, D button subdued grey)/votingand/treasuryCTA buttons render subdued greentransparent*buttons without errorsRefs
🤖 Generated with Claude Code