upcoming: [UIE-9837] - Generational plans changes for Databases#13539
upcoming: [UIE-9837] - Generational plans changes for Databases#13539hana-akamai wants to merge 16 commits intolinode:developfrom
Conversation
… false for resize-database.spec.ts
Cloud Manager UI test results🔺 1 failing test on test run #8 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts" |
|||||||||||||||||
| platform: 'rdbms-default', | ||
| }); | ||
|
|
||
| // const dbtypes = dbtypesData.data as DatabaseType[]; |
There was a problem hiding this comment.
Note: As mentioned in the description, the dbtypes json file that mocks the new response in Database Create and Resize will be removed along with references to it in the code like the line above prior to merging.
| error: typesError, | ||
| isLoading: typesLoading, | ||
| // error: typesError, | ||
| // isLoading: typesLoading, |
There was a problem hiding this comment.
Do we not need typesError and typesLoading?
There was a problem hiding this comment.
It looks like these were just removed for the mock data. Planning to add the checks these were used in back before merging the pull request. See related comment for context.
| error: typesError, | ||
| isLoading: typesLoading, | ||
| // error: typesError, | ||
| // isLoading: typesLoading, |
There was a problem hiding this comment.
Same question that I had in DatabaseCreate. Were these just removed temporarily for testing with mock data? If so, we should probably ad this back along with adding them to the loading state condition.
There was a problem hiding this comment.
After looking over the code, it looks like these were just moved temporarily, so we'll plan to add these back to the loading state when we remove the temporary database types json file and testing code.
Description 📝
Update Database Create and Resize tables to support generational plans changes
Note: I will remove the hardcoded json before merging
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
4/29/26
Preview 📷
See demo attached in internal ticket
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
DatabaseCreate.tsxand around line 96 inDatabaseResize.tsxdatabaseResizeGenerationalPlansisOFF:/databases/typesendpoint and UI LD flagdatabaseResizeGenerationalPlansisON:Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅