feat: use smart git-http-server

[CasLubbers]

📌 Summary

🔍 Reviewer Notes

🧹 Checklist

• Code is readable, maintainable, and robust.
• Unit tests added/updated

[j-zimnowoda]

1. I have successfully deployed. ✅

2. I like the fact that it is using istio sidecar, so mTLS can be set between communicating parties. ✅

3. I am wondering if mtls should be enforced though ⚠️

4. I was also able to clone the repo::white_check_mark:

kubectl port-forward --namespace git-server svc/git-server 9090:80
git clone http://127.0.0.1:9090/otomi/values.git

kubectl get secret git-server-credentials -n git-server -o jsonpath='{.data.password}'

5. After enabling gitea things get messy, so fine tuning needs to be done so the platform does not try to switch to gitea. ⚠️

[j-zimnowoda]

Once PoC is approved we will host it at docker.io/linode

[j-zimnowoda]

We also need to review the code of simple-git-server ?

[ferruhcihan]

Nice work, overall looks good to me. Just consider adding a securityContext (runAsNonRoot, drop capabilities) and/or an egress rule to the network policy to harden the deployment.

[ferruhcihan]

Suggested change

	namespace: {{ .Release.Namespace }}
	namespace: {{ .Release.Namespace }}
	annotations:
	"helm.sh/resource-policy": keep

Should we add this annotation to prevent data loss?

[CasLubbers]

I do not think we need it. After installation we would like that the git-server gets fully teared down. If we add this policy the PVC will keep on existing forever.

[svcAPLBot]

Comparison of Helm chart templating output:

# apl-operator/templates/deployment.yaml

@@ spec.template.spec.containers.apl-operator.image @@
! ± value change
- linode/apl-core:main
+ docker.io/linode/apl-core:main

# New file added: git-server-git-server
# New file added: git-server-git-server-artifacts
# otomi-api/templates/core-config.yaml

@@ data.core.yaml @@
! ± value change in multiline text (one insert, no deletions)
  adminApps:
  - deps:
    - prometheus
    ingress:
  
  [618 lines unchanged)]
  
    - app: harbor
      name: harbor
    - disableIstioInjection: true
      name: apl-harbor-operator
+   - name: git-server
    - name: gitea
    - disableIstioInjection: true
      name: apl-gitea-operator
    - disableIstioInjection: true
  
  [103 lines unchanged)]
  
      svc: tekton-dashboard
      type: public
    name: tekton
    ownHost: true

# otomi-api/templates/deployment.yaml

# rabbitmq-cluster-operator/templates/messaging-topology-operator/validating-webhook-configuration.yaml

# values-repo.yaml

[CasLubbers]

Still need to test migration
Migration is working. Git-server is disabled when migrating and git values are not adjusted.

[j-zimnowoda]

We also need to review the code of simple-git-server ?