feat: improve argocd compatibility with monorepo#2982
Draft
j-zimnowoda wants to merge 122 commits intomainfrom
Draft
feat: improve argocd compatibility with monorepo#2982j-zimnowoda wants to merge 122 commits intomainfrom
j-zimnowoda wants to merge 122 commits intomainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ): ArgocdAppManifest => { | ||
| const name = getAppName(release) | ||
| const patch = (appPatches[name] || genericPatch) as Record<string, any> | ||
| const chartPath = release.chart.replace('../', '') |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 4 days ago
Use a global replacement so all ../ occurrences are removed, not just the first.
Best minimal fix in src/cmd/apply-as-apps.ts (line 147 region): replace
release.chart.replace('../', '')
with
release.chart.replace(/\.\.\//g, '')
This keeps existing functionality (strip parent-directory markers) while making it complete for repeated segments. No new imports, methods, or dependencies are required.
Suggested changeset
1
src/cmd/apply-as-apps.ts
| @@ -144,7 +144,7 @@ | ||
| ): ArgocdAppManifest => { | ||
| const name = getAppName(release) | ||
| const patch = (appPatches[name] || genericPatch) as Record<string, any> | ||
| const chartPath = release.chart.replace('../', '') | ||
| const chartPath = release.chart.replace(/\.\.\//g, '') | ||
| return getArgoCdAppManifest(name, ARGOCD_APP_DEFAULT_LABEL, { | ||
| syncPolicy: ARGOCD_APP_DEFAULT_SYNC_POLICY, | ||
| project: 'default', |
Copilot is powered by AI and may make mistakes. Always verify output.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
🔍 Reviewer Notes
🧹 Checklist