Skip to content

feat: platform secrets as sealed secrets#2978

Merged
ferruhcihan merged 149 commits intomainfrom
APL-523
Apr 16, 2026
Merged

feat: platform secrets as sealed secrets#2978
ferruhcihan merged 149 commits intomainfrom
APL-523

Conversation

@ferruhcihan
Copy link
Copy Markdown
Collaborator

@ferruhcihan ferruhcihan commented Feb 24, 2026

📌 Summary

PRs: apl-api | apl-tasks | apl-console

🔍 Reviewer Notes

🧹 Checklist

  • Code is readable, maintainable, and robust.
  • Unit tests added/updated

Comment thread src/cmd/migrate.ts
Comment thread src/cmd/migrate.ts
Comment thread src/cmd/validate-values.ts Outdated
Comment thread src/common/repo.ts Outdated
Comment thread values/apl-harbor-operator/apl-harbor-operator-raw.gotmpl
Comment thread src/common/sealed-secrets.ts Outdated
Comment thread src/common/sealed-secrets.ts Outdated
Comment thread src/common/repo.ts Outdated
Comment thread values/argocd/argocd-raw.gotmpl Outdated
Comment thread values/argocd/argocd-raw.gotmpl Outdated
Copy link
Copy Markdown
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this enormous work. I successfully deployed the cluster.
It if great to see the ExternalSecrets working in tandem with SealedSecrets!

Besides that I performed various tests to ensure that values rendering does not process encryptedData and that secrets are stored as SealedSecrets in the manifests/** directory.

Remarkable work!

@ferruhcihan ferruhcihan merged commit cc612ca into main Apr 16, 2026
25 of 29 checks passed
@ferruhcihan ferruhcihan deleted the APL-523 branch April 16, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants