dns: set AA flag on responses#36
Open
arekm wants to merge 1 commit intoletsencrypt:mainfrom
Open
Conversation
challtestsrv is authoritative for every name it answers and synthesizes its own SOA in the AUTHORITY section, so replies must have the AA bit set per RFC 1035 §4.1.1. Without it, AA=0 + an authoritative SOA is an internally inconsistent response that DNSSEC validators and strict test harnesses can flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
challtestsrv is authoritative for every name it answers and synthesizes its own SOA in the AUTHORITY section, so replies must have the AA bit set per RFC 1035 4.1.1. Without it, AA=0 + an authoritative SOA is an internally inconsistent response that DNSSEC validators and strict test harnesses can flag.
And that's exactly how I hit this - my test verifies AA flag.