feat(execution): make the VariableRender tolerant about any runtime e…#15505
Merged
loicmathieu merged 2 commits intodevelopfrom Apr 14, 2026
Merged
feat(execution): make the VariableRender tolerant about any runtime e…#15505loicmathieu merged 2 commits intodevelopfrom
loicmathieu merged 2 commits intodevelopfrom
Conversation
Contributor
🐋 Docker imagedocker run --pull=always --rm -it -p 8080:8080 --user=root -v /var/run/docker.sock:/var/run/docker.sock -v /tmp:/tmp ghcr.io/kestra-io/kestra-pr:15505 server local🧪 Java Unit Tests
|
||||||||||||||||||||||||
Contributor
Tests report quick summary:failed ❌ > tests: 4855, success: 4829, skipped: 22, failed: 4
Failed tests:jdbc-postgres > io.kestra.runner.postgres.PostgresServiceLivenessCoordinatorTest > [1] workerGroupKey=workerGroupKey failed ❌ in 32.641jdbc-postgres > io.kestra.runner.postgres.PostgresServiceLivenessCoordinatorTest > [2] workerGroupKey= failed ❌ in 32.412Develocity build scan: https://develocity.kestra.io/s/qsvjnpc47ypue |
loicmathieu
force-pushed
the
feat/variable-renderer-exception
branch
from
56af31a to
5024290
Compare
loicmathieu
added
the
kind/breaking-change
Member
Author
Breaking ChangeI also removed the alternative renderer hook which should only impact the only customer we know that uses it to have a backward compat with Handlebar. |
brian-mulier-p
approved these changes
Apr 13, 2026
Member
brian-mulier-p
left a comment
brian-mulier-p
left a comment
There was a problem hiding this comment.
LGTM but I don't see the runtime exception wrapping you're mentionning 🤔
loicmathieu
force-pushed
the
feat/variable-renderer-exception
branch
2 times, most recently
from
e1c2a82 to
b155000
Compare
…xception Some PebbleFunction may throws RuntimeException, even if it would be cleaner to handle all possible exceptions in all functions, this is practically impossible. To harden the executor and the scheduler, we encapsulate any RuntimeException inside the checked IllegalVariableEvaluationException.
loicmathieu
force-pushed
the
feat/variable-renderer-exception
branch
from
b155000 to
5a88c94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…xception
Some PebbleFunction may throws RuntimeException, even if it would be cleaner to handle all possible exceptions in all functions, this is practically impossible. To harden the executor and the scheduler, we encapsulate any RuntimeException inside the checked IllegalVariableEvaluationException.