chore(docs): optimize AGENTS.md for agent accuracy#15486
Merged
fhussonnois merged 2 commits intodevelopfrom Apr 14, 2026
Merged
chore(docs): optimize AGENTS.md for agent accuracy#15486fhussonnois merged 2 commits intodevelopfrom
fhussonnois merged 2 commits intodevelopfrom
Conversation
Contributor
🐋 Docker imagedocker run --pull=always --rm -it -p 8080:8080 --user=root -v /var/run/docker.sock:/var/run/docker.sock -v /tmp:/tmp ghcr.io/kestra-io/kestra-pr:15486 server local🧪 Java Unit Tests
|
||||||||||||||||||||||||
loicmathieu
requested changes
Apr 10, 2026
Member
loicmathieu
left a comment
loicmathieu
left a comment
There was a problem hiding this comment.
Maybe a single line explaining what Kestra is?
| ``` | ||
|
|
||
| ## Code Style Guidelines | ||
| **DON'T**: Use field injection (`@Inject` on fields directly). Always prefer constructor injection. |
Member
There was a problem hiding this comment.
The only issue with constructor injection is when there are like 20 dependencies, at this stage I prefere field injection (highly debatable, should also be a sign of needing a refactoring to split it)
Member
There was a problem hiding this comment.
Need to check but usually Sonar rules flag constructors with more than 7 or 9 parameters
| ./gradlew build | ||
|
|
||
| # Build without tests (faster) | ||
| ./gradlew build -x test -x integrationTest -x testCodeCoverageReport --refresh-dependencies --no-daemon --parallel |
Member
There was a problem hiding this comment.
Would it be more simpler to only compile? The only caveat would be for UI.
But I would also add a suggestion to at least compile the affected modules as once it changes code without recompilation and ... it fails.
Suggested change
| ./gradlew build -x test -x integrationTest -x testCodeCoverageReport --refresh-dependencies --no-daemon --parallel | |
| ./gradlew build compileTestJava |
loicmathieu
requested changes
Apr 10, 2026
Contributor
Tests report quick summary:failed ❌ > tests: 4845, success: 4819, skipped: 22, failed: 4
Failed tests:jdbc-postgres > io.kestra.runner.postgres.PostgresServiceLivenessCoordinatorTest > [1] workerGroupKey=workerGroupKey failed ❌ in 32.492jdbc-postgres > io.kestra.runner.postgres.PostgresServiceLivenessCoordinatorTest > [2] workerGroupKey= failed ❌ in 32.311Develocity build scan: https://develocity.kestra.io/s/hhd62doj5oebq |
fdelbrayelle
approved these changes
Apr 10, 2026
fhussonnois
force-pushed
the
chore/claude-files
branch
from
f693ba0 to
13e14b2
Compare
Restructure guidelines with critical code patterns (DI, error handling) prioritized at the top in DO/DON'T format. Remove generic "Common Development Tasks" section, consolidate duplicate rules, and reorder sections by violation frequency to improve AI agent code accuracy.
Restructure guidelines with critical code patterns (DI, error handling) prioritized at the top in DO/DON'T format. Remove generic "Common Development Tasks" section, consolidate duplicate rules, and reorder sections by violation frequency to improve AI agent code accuracy.
fhussonnois
force-pushed
the
chore/claude-files
branch
from
13e14b2 to
ea61773
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructure guidelines with critical code patterns (DI, error handling) prioritized at the top in DO/DON'T format. Remove generic "Common Development Tasks" section, consolidate duplicate rules, and reorder sections by violation frequency to improve AI agent code accuracy.
All PRs submitted by external contributors that do not follow this template (including proper description, related issue, and checklist sections) may be automatically closed.
As a general practice, if you plan to work on a specific issue, comment on the issue first and wait to be assigned before starting any actual work. This avoids duplicated work and ensures a smooth contribution process - otherwise, the PR may be automatically closed.