fix(docker): add fail-fast docker socket validation, improve error detection, add tests, and skip integration tests when daemon unavailable#15389
Conversation
|
It looks like the CI failure is unrelated to this PR:
This seems like a flaky test or port conflict in CI. Would you prefer:
Happy to address it separately if needed. |
loicmathieu
left a comment
There was a problem hiding this comment.
This seems overly complicated.
What I don't unrestand is that we had a code block to handle specifically this kind of exception but it seems it didn't work, maybe fix that code block instead of removing it and replacing it?
|
Thanks for the feedback! You're right — the current approach introduces duplication between the pre-validation and the exception handling block. My intention was to:
But I see that this overlaps with the existing logic. I'll refactor this to:
Will push an updated version shortly. |
…tection, add tests, and skip integration tests when daemon unavailable
eee6674 to
4581cce
Compare
|
Thanks for the review @loicmathieu! I’ve refactored the implementation to remove duplication and simplify the flow:
This makes the behavior more consistent and easier to follow. Regarding the CI failure: it occurs in jdbc-postgres (PostgresServiceLivenessCoordinatorTest) and appears unrelated to this PR. The script module (where these changes were made) is passing all tests successfully. This looks like a flaky or environment-related issue, but I’m happy to re-run the workflow or investigate further if needed. |
|
Backported to 1.3 and 1.0 |
|
Thanks @loicmathieu and @MilosPaunovic for the review and quick merge! Glad the refactor aligns well. Appreciate the backport as well 🙌 |
✨ Description
This PR improves Docker error handling by introducing a fail-fast validation for Unix socket-based Docker hosts.
This ensures a clear separation between environment/setup failures and container execution failures, improving reliability and debuggability.
🔗 Related Issue
Closes #15161
🛠️ Backend Checklist
📝 Additional Notes
Add any extra context or details reviewers should be aware of.