Maintenance 2026-04 and bug fix#84
Merged
Merged
Conversation
DoraGenc
changed the title
DoraGenc
force-pushed
the
maintenance-2026-04
branch
from
1b089f0 to
60f6620
Compare
Contributor
|
Minor is ok for this. IMO, we could consider releasing a v1.0.0 soon, this gem seems quite mature now. |
brerx
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:mock_earsmethodBug Fix
The update to bunny v3.0.0 introduces a breaking change. It now requires
:record_exchangeto be mocked onBunny::Channel. Since our current version constraint for ears resolves to the latest bunny version (anything above 2.22.0), the update pulls v3.0.0 automatically. This then breaks our:mock_earsmethod because it doesn't yet mock the new method.This raises the question of what kind of version we should release: major, minor, or patch.
Since updating the ears requires using a new major version of Bunny, a major release could be justified.
However, as this is ultimately just a bug fix and not directly related to the ears themselves, a major release might be too much (especially because we are on v0.x.x right now) and a minor release could be more appropriate.
At the same time, one could argue that this is simply a bug fix, in which case a patch release would be sufficient.
Overall, I tend to lean toward either a major or a minor release version. What do you think?