Check database version in CLI#66
Open
Yannicked wants to merge 3 commits intoiterorganization:developfrom
Open
Conversation
Yannicked
requested review from
SimonPinches,
deepakmaroo,
maarten-ic and
olivhoenen
as code owners
maarten-ic
reviewed
Apr 10, 2026
| else: | ||
| raise e | ||
| except DatabaseOutdatedError as e: | ||
| if Confirm.ask("Local database schema is out of date. Run migrations now?"): |
Collaborator
There was a problem hiding this comment.
Would you recommend users create a backup of the existing database (or even create it automatically for them) in case the migration fails?
Contributor
There was a problem hiding this comment.
It would not be easy to find database files and restore (if something went wrong) for every user. I would suggest to create database backup automatically and incase if migration fails should be able to rollback.
Contributor
There was a problem hiding this comment.
Also good to inform the user is what is backed up and where it stored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifies the local database version using alembic