refactor(many): extract raw svgs for cross-package use#2543
Draft
HouseOfHawks wants to merge 160 commits into
Draft
refactor(many): extract raw svgs for cross-package use#2543HouseOfHawks wants to merge 160 commits into
HouseOfHawks wants to merge 160 commits into
Conversation
… not include functional components
For now it only parses V1 components. It also does not parse components that use the new structure and there are several CSS errors
…ort (now withStyleLegacy)
…> v11_6, v11_6->v11_7)
INSTUI-4789 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
INSTUI-4815
…ustom/brand icon components and migration codemod
…hey are all deprecated
…y restoring focus to hidden input
GitHub Pages only supports a single 404.html at the repo root. When navigating to sub-routes in PR previews (e.g. /pr-preview/pr-123/Button), the root 404.html was serving the production app instead of the PR preview build. A redirect script in index.html detects PR preview paths and redirects to the PR preview's index.html with the route encoded as a query parameter. The app entry point restores the original clean URL via history.replaceState before rendering.
INSTUI-4783
|
|
…ing exports there were some exports that were missing after the multi version upgrade. Add them back with the proper path
|
HouseOfHawks
force-pushed
the
TASTY-1731
branch
2 times, most recently
from
29a3d3b to
68f4ad5
Compare
…DateInput v1 with DateInput v2 in DateTimeInput
BREAKING CHANGE: prevMonthLabel prop removed (use screenReaderLabels.prevMonthButton instead)
nextMonthLabel prop removed (use screenReaderLabels.nextMonthButton instead)
renderWeekdayLabels prop removed
dateFormat type changed: string → string
{ parser: (input: string) => Date
null, formatter: (date: Date) => string }
screenReaderLabels is a new required prop
dateFormat default changed: Moment's 'LL' (long month name) → locale's default date format
INSTUI-4791
…eplacing Chromatic Capture full-page screenshots via cy.screenshot() in an afterEach hook, record each test's visited URL via a cy.task for source-file linking, diff against baselines stored on a visual-baselines branch using a new `ui-scripts visual-diff` command, and publish an HTML report per PR to gh-pages with a sticky PR comment linking to it. The regression-test Next.js app now uses `output: 'export'` with `trailingSlash: true`, serving a fully static site through http-server — no SSR and no hydration so captures are byte-deterministic. The report has a lightbox viewer with baseline/actual/diff mode toggle, a draggable slider overlay, fit-to-window and 1:1 zoom, prev/next navigation, a PR number link in the header, per-row source-file links back to the GitHub blob URL, a debounced live search box, and highlighted active filter buttons. The sticky PR comment includes a collapsed <details> block with inline diff images for every changed row. Documentation added at docs/testing/visual-regression.md. Removes the Chromatic integration; CHROMATIC_APP_CODE secret is no longer used. Baselines are seeded automatically by the new visual-baselines workflow on every merge to master. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
… definition so they can build their own components with InstUI
…form component docs INSTUI-4944
BREAKING CHANGE: `thumbVariant` prop removed from RangeInput INSTUI-5016
…DateInput v1 with DateInput v2 in DateTimeInput BREAKING CHANGE: renderWeekdayLabels` prop removed `calendarIcon` is a new required prop INSTUI-4791
…elected on calendar days, BREAKING CHANGE: add mandatory prop selectedLabel, change datePickerDialog prop to mandatory
The content wrapper changed from display:block to display:flex in the v2 button rewrite, which made textAlign:center ineffective on the shrunk children span. Add justifyContent based on textAlign so text is centered regardless of whether an icon is present. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
core-js was fixing really niche bugs in the code ze.g. map.getOrInsertComputed, map.getOrInsert and an exotic Safari bug https://bugs.webkit.org/show_bug.cgi?id=309342 that is fixed in Webkit nightly. Remove core-js because its no longer needed
extracted raw svgs into a new ui-icons-svg package and added as a dependency in ui-icons feat(ui-scripts,ui-icons,ui-icons-svg): added parchment assets added parchment icons, vectors and graphics retooled script bundling to support parchment asset categories extended demo app to conditionally render all icons by org extended demo app to conditionally render parchment icons by type refactor(ui-icons-svg): icons cleanup cleaned up now unused directory refactor(ui-scripts): typescript fix fix(github actions): pin chromaui/action to v11 ci(github actions): removed debugging change
Visual regression report✅ No changes.
Baselines come from the |
Collaborator
|
Can you please add a postfix to the new icons? e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
ui-icons-svgpackage, free of framework dependencies, for use in other icon-generating packages,ui-icons-svg/svg/Parchmentfor allGraphics,IconsandVectorsused in Parchment, Digitary, Scribbles and Quottly applications,ui-iconswhile making new Parchment icons available in this React package (both legacy and beta), and__docs__app so that consumers can now filter icons by organization type and asset type when viewing Parchment assets (demo below)Demo:
Screen.Recording.2026-05-06.at.8.46.53.AM.mov
Next iterations (ongoing work):
Currently there is significant asset overlap. Design teams will need to work through both asset libraries and unify that overlap (ie, InstUI's
x.svgand Parchment'sclose.svg). Parchment application developers will need access to this full set of assets initially as teams begin implementing InstUI, but as re-design work becomes available those teams will be pointed to the InstUI icons where applicable. In other cases where assets are Parchment-specific or there is no InstUI counterpart, those Parchment assets will remain.