chore(ui-utils): remove unused hash utility#2540
Open
HerrTopi wants to merge 142 commits into
Open
Conversation
… not include functional components
For now it only parses V1 components. It also does not parse components that use the new structure and there are several CSS errors
…ort (now withStyleLegacy)
…> v11_6, v11_6->v11_7)
INSTUI-4789 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
INSTUI-4815
…ustom/brand icon components and migration codemod
…hey are all deprecated
…y restoring focus to hidden input
GitHub Pages only supports a single 404.html at the repo root. When navigating to sub-routes in PR previews (e.g. /pr-preview/pr-123/Button), the root 404.html was serving the production app instead of the PR preview build. A redirect script in index.html detects PR preview paths and redirects to the PR preview's index.html with the route encoded as a query parameter. The app entry point restores the original clean URL via history.replaceState before rendering.
INSTUI-4783
The v2 Text component uses the 'primary' color by default, v1 none (inherit). Add an 'inherit' value to v2 Text, so previous behaviour can be emulated
…Webpack 4 support We have removed lots of smaller Babel plugins. In theory these were just doing transforms that are used by old browsers and all features should be supported. make the internal webpack config much more simple Completes INSTUI-4831
The hash() function exported from @instructure/ui-utils has no internal callers — only its own test imports it. Drop the module, its test, the export from the package index, and the json-stable-stringify dependency that existed solely to support it.
|
matyasf
requested changes
May 6, 2026
| export { cloneArray } from './cloneArray' | ||
| export { createChainedFunction } from './createChainedFunction' | ||
| export { deepEqual } from './deepEqual' | ||
| export { hash } from './hash' |
Collaborator
There was a problem hiding this comment.
This might be used by others, please do not remove it!
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hash()exported from@instructure/ui-utilshas no internal callers — the only importer in the repo is its own testpackages/ui-utils/src/hash.ts, its test, the re-export fromsrc/index.ts, and thejson-stable-stringifydependency that existed solely to back itTest plan
pnpm installresolves cleanlypnpm run build:typessucceedspnpm run test:vitest ui-utilspassespnpm run test:vitestpasses