Exempt wsproto from license check#156418
Merged
cdce8p merged 2 commits intohome-assistant:devfrom Nov 12, 2025
Merged
Conversation
wsproto from license checkwsproto from license check
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR temporarily exempts the wsproto package from the license check script until its MIT license identifier is restored upstream. The package's MIT license file still exists but the metadata was inadvertently removed when migrating from setup.py to pyproject.toml in version 1.3.0.
Key changes:
- Added
wsprototo theEXCEPTIONSset in the license check script with a reference to the upstream fix PR - Bumped the CI cache version from 1 to 2 to ensure CI uses the newer library version that triggers the license check failure
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| script/licenses.py | Added wsproto to the EXCEPTIONS set with reference to upstream PR #194 |
| .github/workflows/ci.yaml | Bumped CACHE_VERSION from 1 to 2 to invalidate cached CI environment |
21 tasks
cdce8p
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This (temporarily) exempts
wsprotofrom the license check until the MIT license identifier is added back with:pyproject.tomlpython-hyper/wsproto#194The CI cache version is also bumped, as this isn't a dependency we pin ourselves.
(it was knocked down to
1a few weeks ago with #154988, so bumping to2).The currently cached CI venv still uses an older library version from 2022: 1.2.0.
So, we've not started seeing the failures on
dev, yet. See the sections below where the issue appeared.Background
The MIT license is still present: python-hyper/wsproto/LICENSE, but both the (incorrect) identifier and (correct) classifier were dropped when moving from
setup.pytopyproject.tomlwith python-hyper/wsproto@d7ed47f, released with v1.3.0.Spotted in
This failure was spotted here:
Usage in HA
This transitive dependency is required by three integrations:
ambient_network,tami4, andyalexs_ble.Dependency usage (CLICK TO OPEN)
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: