Support newer python daemon package#87
Open
rkojedzinszky wants to merge 2 commits intogrnet:masterfrom
Open
Conversation
ioparaskev
suggested changes
Apr 12, 2018
Contributor
ioparaskev
left a comment
ioparaskev
left a comment
There was a problem hiding this comment.
Since these are breaking changes (in case someone doesn't update the python-daemon version) a more regression-friendly should be used.
For example
try:
import daemon.pidlockfile as daemon_pid
except ImportError:
import daemon.pidfile as daemon_pidand then use the daemon_pid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.