fix(grain): Correct empty resource generation#3
Open
spotandjake wants to merge 1 commit intograin-lang:grainfrom
Open
fix(grain): Correct empty resource generation#3spotandjake wants to merge 1 commit intograin-lang:grainfrom
spotandjake wants to merge 1 commit intograin-lang:grainfrom
Conversation
ospencer
approved these changes
Jan 2, 2025
Member
|
@spotandjake Looks like you need to fix conflicts. |
spotandjake
force-pushed
the
spotandjake-grain-fix-resource
branch
from
9aee988 to
c431d39
Compare
spotandjake
force-pushed
the
spotandjake-grain-fix-resource
branch
from
c431d39 to
cafb7d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr corrects the way we generate bindings for:
before we would generate an empty module which didn't really make sense so now this just generates the type defintion for the resource handle if there is no functions.
This pr currently is built ontop of the changes in #2 so it needs to be merged first, I can seperate these if needed but it was easier for me to just combine them so I had a working branch.