Open
Conversation
…because dockable widgets no longer are supported, need to migrate everything to a SidebarWidget
…across CoverageOverview and lighthousewidget.visible not existing, still need large changes to migrate out of dockablewidgets.
…on't need to do that though. Also render layer not displaying in layers menu
…working for disassembly view
Fully completed the IL porting, however, there's still some issues with the error message handling when we load a coverage file and there's no Lighthouse Sidebar that's open. Everything else works though. Oh, and there's an annoying issue with how binary ninja shows a render layer to the user within the render layer settings.
Author
|
I wasn't quite able to come up with a good way to accomplish a force refresh of the UI, so when a coverage file is loaded for the first time it won't render the layer correctly. I don't quite know what a solution would be, there were some C++ hacks that existed with marking stuff as dirty, but it didn't work me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, while I was fixing #163 I also noticed that I could go ahead and migrate the old usage of the highlighter API to use the new RenderLayers API released with binary ninja 5.0. Although this PR is built on top of #163 because otherwise displaying coverages didn't work.
I did use AI to get up and running but it does work and is tested on Binary Ninja 5.2.8614-stable.