Fix Python 3.14 compatibility issue with pypika for the docker deployment bench script#1608
Open
siparker wants to merge 2 commits intofrappe:developfrom
Open
Fix Python 3.14 compatibility issue with pypika for the docker deployment bench script#1608siparker wants to merge 2 commits intofrappe:developfrom
siparker wants to merge 2 commits intofrappe:developfrom
Conversation
Removed obsolete version: "3.7" field (fixes Docker Compose warning) Added comments regarding Python version compatibility for frappe service.
Fixed shebang: #!bin/bash → #!/bin/bash Added Python version compatibility checking (lines 11-119) Automatic pyenv initialization and Python 3.11/3.12 detection Auto-install Python 3.11 via pyenv if missing Fallback to system python3.11 or python3.12 with PATH manipulation Clear error messages if Python 3.14+ is detected and no compatible version is available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker CRM setup fails because pypika==0.48.9 is incompatible with Python 3.14.2. The frappe/bench:latest Docker image uses Python 3.14.2, which removed the ast.Str attribute that pypika relies on.
Added python version detection and automatic fallback to py 3.11 or 3.12 via pyenv.
It now deploys correctly in docker.