chore: Resolved CI build failures on PyPy 3.9 by pinning cryptography#952
Merged
lahirumaramba merged 1 commit intomainfrom May 7, 2026
Merged
chore: Resolved CI build failures on PyPy 3.9 by pinning cryptography#952lahirumaramba merged 1 commit intomainfrom
cryptography#952lahirumaramba merged 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a version constraint for the cryptography library in both requirements.txt and setup.py, specifically limiting it to versions below 44.0.0 for PyPy environments running Python versions earlier than 3.11. I have no feedback to provide as there are no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer versions of the
cryptographypackage (>= 44.0.0) upgraded their internal RustPyO3dependency to a version that requires PyPy >= 3.11. Consequently, buildingcryptographyfrom source fails in older PyPy environments likepypy3.9.This PR introduces an environment marker constraint to restrict
cryptography < 44.0.0on PyPy interpreters older than 3.11, ensuring stable dependency resolution and restoring successful builds.