Update FIP-0115: Move to Last Call#1246
Merged
jsoares merged 1 commit intoThatGuyLLC-patch-1from Apr 14, 2026
Merged
Conversation
wjmelements
requested review from
TippyFlitsUK,
anorth,
dannyob,
jennijuju,
jsoares,
lanzafame,
momack2 and
rvagg
as code owners
jsoares
approved these changes
Mar 23, 2026
rvagg
approved these changes
Apr 2, 2026
Member
rvagg
left a comment
rvagg
left a comment
There was a problem hiding this comment.
I'm going to leave the final step to @ThatGuyLLC who's working through the FIPs pipeline atm but afaik last call was on the cards for this FIP anyway?
Member
In theory, last call is the author's decision, provided serious feedback has been addressed. I realise we often deviate from theory here, but I see no reason to hold this. |
jsoares
approved these changes
Apr 11, 2026
momack2
pushed a commit
that referenced
this pull request
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer @jsoares
FIP-0115 has implementations on Lotus, Venus, and Forest.
The implementations all have good test coverage including the test cases in the FIP.
Changes