Fix Noticed::DeliveryMethods::Email to support keyword arguments#565
Closed
tcannonfodder wants to merge 1 commit intoexcid3:mainfrom
Closed
Fix Noticed::DeliveryMethods::Email to support keyword arguments#565tcannonfodder wants to merge 1 commit intoexcid3:mainfrom
Noticed::DeliveryMethods::Email to support keyword arguments#565tcannonfodder wants to merge 1 commit intoexcid3:mainfrom
Conversation
* Mailers with keyword arguments were not able to be used by the `Noticed::DeliveryMethods::Email` because the arguments were not double-splatted to convert a hash to the arguments the mailer expects * To support keyword arguments in mailers, while maintaining backward compatability with existing configurations, a new `kwargs` option is available * If present, the mailer will be called with `public_send(name, **kwargs)`, to properly convert the hash of argument to keyword arguments as Ruby expects them * When delivering, `kwargs` and `args` cannot both be present, because only one can be used. In this case, an `ArgumentError` will be thrown * Added unit tests for the new behavior, along with documentation for the new option
Owner
|
Thanks @tcannonfodder! Surprised I forgot to add this haha. There should be a way for us to pass both args and kwargs together. I'm going to see if I can figure out how to do that. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary:
Fix
Noticed::DeliveryMethods::Emailto support keyword argumentsRelated Issue:
#564
Description:
Noticed::DeliveryMethods::Emailbecause the arguments were not double-splatted to convert a hash to the arguments the mailer expectskwargsoption is availablepublic_send(name, **kwargs), to properly convert the hash of argument to keyword arguments as Ruby expects themkwargsandargscannot both be present, because only one can be used. In this case, anArgumentErrorwill be thrownTesting:
Checklist: